Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support Django 3.0 #601

Closed
uri-rodberg opened this issue Dec 2, 2019 · 11 comments · Fixed by #605
Closed

Support Django 3.0 #601

uri-rodberg opened this issue Dec 2, 2019 · 11 comments · Fixed by #605
Assignees
@camilonova

Comments

@uri-rodberg
Copy link
Contributor

This line does not work with Django 3.0:

from django.utils.encoding import python_2_unicode_compatible

https://docs.djangoproject.com/en/3.0/releases/3.0/

You can import directly from six if you still need to support Python 2.
@hugodes hugodes mentioned this issue Dec 3, 2019
Closed
@hugodes
Copy link

hugodes commented Dec 3, 2019

As far as I can see a PR has been made: #600

@hugodes hugodes mentioned this issue Dec 3, 2019
Merged
@uri-rodberg
Copy link
Contributor Author

As far as I can see a PR has been made: #600

You can close this issue after Django 3.0 is supported in the latest release.

@devova
Copy link

devova commented Dec 9, 2019

#600 is merged but no tag/release has been made!

@moseb
Copy link

moseb commented Dec 12, 2019

A new release would be lovely please please 😄

@hugodes
Copy link

hugodes commented Dec 13, 2019

Pretty please @camilonova 🙏🏻

@jmsmkn jmsmkn mentioned this issue Dec 17, 2019
Closed
@bfincher
Copy link

You can update your requirements.txt file with the following line until a release is made: git+git://github.com/jazzband/sorl-thumbnail@4fe1854#egg=sorl-thumbnail

@itsthejoker itsthejoker mentioned this issue Dec 19, 2019
Closed
@danidee10
Copy link

Just adding my voice here. Please make a release! 🙏 Thanks

@benjaoming benjaoming mentioned this issue Dec 20, 2019
Merged
@camilonova camilonova self-assigned this Dec 23, 2019
@camilonova
Copy link
Member

Someone please approve #604

@slyapustin slyapustin mentioned this issue Dec 26, 2019
Merged
@slyapustin
Copy link

@benjaoming Can you please approve #604?

@benjaoming benjaoming mentioned this issue Dec 27, 2019
Merged
@benjaoming
Copy link
Contributor

@inoks I already approved it, that has no effect. I don't have write access to the repo as noted in #604.

@yuweichen1008
Copy link

The bug seems to unfix at Django 3.0

@studybuffalo studybuffalo mentioned this issue Jan 13, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@camilonova camilonova

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

12.6.0 release benjaoming/sorl-thumbnail
10 participants
@camilonova @slyapustin @benjaoming @hugodes @bfincher @devova @danidee10 @uri-rodberg @yuweichen1008 @moseb