Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Known issue: sorl-thumbnail does not support Django 3.0 #992

Closed
benjaoming opened this issue Nov 19, 2019 · 5 comments · Fixed by #1019
Closed

Known issue: sorl-thumbnail does not support Django 3.0 #992

benjaoming opened this issue Nov 19, 2019 · 5 comments · Fixed by #1019
Labels
bug Confirmed bug

Comments

@benjaoming
Copy link
Member

Need to create upstream support. Here's a recipe for adding Django 3.0 for their test framework.

jazzband/sorl-thumbnail@22ccd97

There are imports in Sorl that are broken in Django 3.0:

https://github.com/jazzband/sorl-thumbnail/blob/master/sorl/thumbnail/images.py#L10

@benjaoming benjaoming changed the title Know issue: sorl-thumbnail does not support Django 3.0 Known issue: sorl-thumbnail does not support Django 3.0 Nov 19, 2019
@itsthejoker
Copy link

The fix has been merged and is available, but the maintainer has not created a release yet. See here for more information: jazzband/sorl-thumbnail#601

@benjaoming
Copy link
Member Author

Still waiting for a new release.

@benjaoming benjaoming added the bug Confirmed bug label Jan 7, 2020
@pallavg
Copy link

pallavg commented Jan 23, 2020

Hello - has there been any movement on getting the dependencies supported for Django 3?

@slinkymanbyday
Copy link

sorl-thumbnail 12.6.2 is on PyPI and support django 3.0+

django-mptt has 0.11 released on PyPI and should contain DJango 3.0 support.

is there anything else blocking django 3? would like to be able to activate my wiki again on my django 3 project.

@benjaoming
Copy link
Member Author

working that out @slinkymanbyday

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Confirmed bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants