overwrite only backstage and init-dynamic-plugins image. fix for https://issues.redhat.com/browse/RHIDP-1701 #279
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rm3l
reviewed
Mar 27, 2024
There was a problem hiding this comment.
test -s /home/runner/work/operator/operator/bin/controller-gen || GOBIN=/home/runner/work/operator/operator/bin go install sigs.k8s.io/controller-tools/cmd/controller-gen@v0.11.3
/home/runner/work/operator/operator/bin/controller-gen rbac:roleName=manager-role crd webhook paths="./..." output:crd:artifacts:config=config/crd/bases
/home/runner/work/operator/operator/bin/controller-gen object:headerFile="hack/boilerplate.go.txt" paths="./..."
test -s /home/runner/work/operator/operator/bin/goimports || GOBIN=/home/runner/work/operator/operator/bin go install golang.org/x/tools/cmd/goimports@v0.15.0
find . -not -path '*/\.*' -name '*.go' -exec /home/runner/work/operator/operator/bin/goimports -w {} \;
go vet ./...
test -s /home/runner/work/operator/operator/bin/setup-envtest || GOBIN=/home/runner/work/operator/operator/bin go install sigs.k[8](https://github.com/janus-idp/operator/actions/runs/8451633049/job/23150369560?pr=279#step:6:9)s.io/controller-runtime/tools/setup-envtest@latest
go: downloading sigs.k8s.io/controller-runtime/tools/setup-envtest v0.0.0-2024032603111[9](https://github.com/janus-idp/operator/actions/runs/8451633049/job/23150369560?pr=279#step:6:10)-8afbb50e0eb2
go: sigs.k8s.io/controller-runtime/tools/setup-envtest@latest (in sigs.k8s.io/controller-runtime/tools/setup-envtest@v0.0.0-20240326031119-8afbb50e0eb2): go.mod:3: invalid go version '1.22.0': must match format 1.23
make: *** [Makefile:250: /home/runner/work/operator/operator/bin/setup-envtest] Error 1
Error: Process completed with exit code 2.
Tests are failing because of setup-envtest. This was fixed in #278 (cherry-picked in #280). Could you please rebase your branch onto 1.1.x ?
rm3l
requested changes
Mar 27, 2024
rm3l
reviewed
Mar 27, 2024
rm3l
reviewed
Mar 28, 2024
|
rm3l
approved these changes
Apr 2, 2024
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rm3l The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Which issue(s) does this PR fix or relate to
https://issues.redhat.com/browse/RHIDP-1701
PR acceptance criteria