Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

overwrite only backstage and init-dynamic-plugins image. #295

Conversation

gazarenkov
Copy link
Collaborator

Description

fix for https://issues.redhat.com/browse/RHIDP-1701

Which issue(s) does this PR fix or relate to

https://issues.redhat.com/browse/RHIDP-1701

PR acceptance criteria

  • Tests included

pkg/model/deployment.go Outdated Show resolved Hide resolved
pkg/model/deployment_test.go Show resolved Hide resolved
pkg/model/deployment_test.go Show resolved Hide resolved
Copy link

sonarcloud bot commented Apr 5, 2024

Quality Gate Passed Quality Gate passed

Issues
1 New issue
5 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.3% Duplication on New Code

See analysis details on SonarCloud

pkg/model/testdata/sidecar-deployment.yaml Dismissed Show dismissed Hide dismissed
pkg/model/testdata/sidecar-deployment.yaml Dismissed Show dismissed Hide dismissed
pkg/model/testdata/sidecar-deployment.yaml Dismissed Show dismissed Hide dismissed
pkg/model/testdata/sidecar-deployment.yaml Dismissed Show dismissed Hide dismissed
pkg/model/testdata/sidecar-deployment.yaml Dismissed Show dismissed Hide dismissed
@gazarenkov gazarenkov requested a review from rm3l April 5, 2024 16:00
@openshift-ci openshift-ci bot added the lgtm PR is ready to be merged. Required by Prow. label Apr 8, 2024
Copy link

openshift-ci bot commented Apr 8, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rm3l

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved PR has been approved by an approver from all required OWNERS files. Required by Prow. label Apr 8, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit e3a07de into janus-idp:main Apr 8, 2024
10 checks passed
@gazarenkov gazarenkov deleted the replace_images-on-only-certain-containers branch April 19, 2024 08:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved PR has been approved by an approver from all required OWNERS files. Required by Prow. lgtm PR is ready to be merged. Required by Prow.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants