lanp: Fix error response from Unsupported Parameter lookup #389
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
osenft
previously approved these changes
Dec 21, 2022
dvanallen
force-pushed
the
bugfix/388-fix-lanp-unsupported-param
branch
from
146e209
to
9d1247f
Compare
osenft
approved these changes
Jan 9, 2023
osenft
previously approved these changes
Jan 9, 2023
|
Could you please add a few lines about the broken behavior w/o the fix, the expected behavior and which platform you tested this on? |
Oh, sorry, you have it in the issue #388. My bad. |
|
@AlexanderAmelkin please let me know if you'd like me to keep syncing this branch to master, I don't want to change it out from underneath you or make @osenft's review stale if you're actively trying to review it. |
AlexanderAmelkin
suggested changes
Jan 11, 2023
dvanallen
force-pushed
the
bugfix/388-fix-lanp-unsupported-param
branch
2 times, most recently
from
2e7ef48
to
d816779
Compare
Return a pointer to the lan_param instead of NULL in the case when the parameter is not supported. Resolves ipmitool#388 Signed-off-by Daniel Van Allen <dvanallen@google.com>
dvanallen
force-pushed
the
bugfix/388-fix-lanp-unsupported-param
branch
from
d816779
to
a61349b
Compare
|
Any updates on the outlook for this? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Return a pointer to the lan_param instead of NULL in the case when the parameter is not supported.
Resolves #388
Signed-off-by Daniel Van Allen dvanallen@google.com