Unsupported LAN Parameter lookup command returns an error

[dvanallen]

When using ipmitool lan print, an error (exit status 1) is returned for an Unsupported Parameter in versions which include the change 351dad2.

IPMITOOL Version

ipmitool -V
ipmitool version 1.8.19.4.g63d59a5

To Reproduce
Steps to reproduce the behavior:

1. Using Dell R740 server with Linux 5.15
2. Run ipmitool -vvvvv lan print
3. Observe the abnormal log message and exit code 1:

   Get LAN Parameter 'Bad Password Threshold' command failed: Unsupported parameter
   

Expected behavior
Function get_lan_param_select should not return NULL, as described in the function comment at

ipmitool/lib/ipmi_lanp.c

Lines 179 to 181 in 63d59a5

	* if parameter not supported then
	* return pointer to lan_param with
	* lan_param->data == NULL and lan_param->data_len == 0

. The ipmitool lan print command should return exit code 0.

[osenft]

I expect this to be an issue on all current Dell machines with iDRAC BMC, since AFAIK these do not implement the "bad password threshold" parameter.

[rustydb]

We are also seeing this on iLO5 BMCs as well.

Set in Progress         : Set Complete
Auth Type Support       : NONE MD5 PASSWORD
Auth Type Enable        : Callback : MD5 PASSWORD
                        : User     : MD5 PASSWORD
                        : Operator : MD5 PASSWORD
                        : Admin    : MD5 PASSWORD
                        : OEM      :
IP Address Source       : Static Address
IP Address              : <redacted>
Subnet Mask             : 255.255.255.0
MAC Address             : 94:40:c9:37:77:ce
SNMP Community String   :

with -v:

Loading IANA PEN Registry...
Using best available cipher suite 3

Running Get VSO Capabilities my_addr 0x20, transit 0, target 0x20
Invalid completion code received: Invalid command
Discovered IPMB address 0x0
Set in Progress         : Set Complete
Auth Type Support       : NONE MD5 PASSWORD
Auth Type Enable        : Callback : MD5 PASSWORD
                        : User     : MD5 PASSWORD
                        : Operator : MD5 PASSWORD
                        : Admin    : MD5 PASSWORD
                        : OEM      :
IP Address Source       : Static Address
IP Address              : <redacted>
Subnet Mask             : 255.255.255.0
MAC Address             : 94:40:c9:37:77:ce
SNMP Community String   :
Get LAN Parameter 'IP Header' command failed: Unsupported parameter

rpm -q ipmitool
ipmitool-1.8.18.238.gb7adc1d-150400.1.14.x86_64

We've worked around it by rolling back to 7ccea28, which is the commit hash SLES15SP3 used for its ipmitool package. https://build.opensuse.org/package/show/SUSE:SLE-15-SP3:Update/ipmitool

The invalid parameter still occurs but it doesn't exit early.

[rustydb]

I tested the change in #389 against the current HEAD of ipmitool/ipmitool and it resolved the issue for us with regards to our iLO BMCs. Errors are thrown when -v (verbose) is used, but the command does not return early.