Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add jhipster starter for Ionic4 #749

Closed
wants to merge 1 commit into from

Conversation

fleboulch
Copy link
Contributor

No description provided.

@fleboulch
Copy link
Contributor Author

@mraible
CI is failing and I saw in history you spent some times to get tests passing.
Do you have an idea about this issue or do you know someone else to help me to fix CI?

Some pointers about my search

@mraible
Copy link
Contributor

mraible commented May 14, 2019

@fleboulch Do the Jest tests pass when you run them locally? If so, maybe @dwieeb can help.

Also, this branch is out-of-date, so you might want to update it.

@fleboulch
Copy link
Contributor Author

fleboulch commented May 14, 2019

@mraible no they don't pass on local and my attempts don't make the tests green
Yes I will rebase it

@mraible
Copy link
Contributor

mraible commented May 18, 2019

@fleboulch I created a new PR that (hopefully) fixes the tests: #759

@fleboulch
Copy link
Contributor Author

awesome @mraible
thanks a lot ! I think we should update the generator to offer only ionic3 starter as v4 starter doesn't provide entity support yet.
I started working on it but it's not ready for production

@vivekmore
Copy link

@mraible @fleboulch
I believe I got the unit tests passing locally.
   https://github.com/oktadeveloper/generator-jhipster-ionic/pull/70 

@mhartington
Copy link
Member

closing as of #759

@fleboulch fleboulch deleted the jhipster-ionic4 branch May 21, 2019 08:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants