Use updated API method from main generator to load configs #69

pmverma · 2019-05-15T05:01:04Z

pmverma · 2019-05-15T05:14:00Z

Getting following error.

Creating Ionic app with command: ionic start ionic4j oktadeveloper/jhipster --no-interactive
(node:7564) ExperimentalWarning: The http2 module is an experimental API.
[ERROR] Unable to find starter template for oktadeveloper/jhipster
        
        If this is not a typo, please make sure it is a valid starter template 
        within the starters repo: https://github.com/ionic-team/starters
events.js:137
      throw er; // Unhandled 'error' event
      ^
TypeError: Cannot set property 'author' of undefined
    at module.exports.install (/home/travis/generator-jhipster-ionic/generators/app/index.js:153:28)
    at Object.<anonymous> (/home/travis/generator-jhipster-ionic/node_modules/generator-jhipster/node_modules/yeoman-generator/lib/index.js:399:25)
    at /home/travis/generator-jhipster-ionic/node_modules/generator-jhipster/node_modules/run-async/index.js:25:25
    at new Promise (<anonymous>)
    at /home/travis/generator-jhipster-ionic/node_modules/generator-jhipster/node_modules/run-async/index.js:24:19
    at self.env.runLoop.add.completed (/home/travis/generator-jhipster-ionic/node_modules/generator-jhipster/node_modules/yeoman-generator/lib/index.js:400:11)
    at runCallback (timers.js:756:18)
    at tryOnImmediate (timers.js:717:5)
    at processImmediate [as _immediateCallback] (timers.js:697:5)
The command "$JHIPSTER_SCRIPTS/02-generate-project.sh" exited with 1.

pmverma · 2019-05-15T11:43:10Z

I think build error is due to v4.

mraible · 2019-05-15T12:20:36Z

See #68 (comment)

This module only works with Ionic 3 and JHipster 5. We’re working on a version that works with Ionic 4 and JHipster 6. We have to get the starter integrated first. Follow ionic-team/starters#749 to see when that is complete.

pmverma · 2019-05-15T13:48:11Z

Thanks @mraible

fleboulch · 2019-05-17T13:56:58Z

generators/app/index.js

@@ -129,9 +129,9 @@ module.exports = class extends BaseGenerator {
            this.error(`\nYour backend project must be a monolith or a gateway to work with this module! Found application type: ${applicationType}.\n`);
        }

-        const cmd = `ionic start ${this.ionicAppName} oktadeveloper/jhipster${(this.interactive) ? '' : ' --no-interactive'}`;
+        const cmd = `ionic start ${this.ionicAppName} https://github.com/oktadeveloper/ionic-jhipster-starter${(this.interactive) ? '' : ' --no-interactive'}`;


@pmverma
The support for V4 is still not finished. We need to add entity support as V3 does.
So this change can't be added right now.
To fix this you can run the ionic start command with the flag --type=ionic-angular for Ionic v4

Thanks @fleboulch. I am going to close this PR as I notice v4 support is already in progress.

i will go to try this..

Use updated API method from main generator

db4224e

pmverma added 3 commits May 15, 2019 13:25

fix failing build by using latest version of main generator

44a097b

update jhipster version to pass the build

4882a9b

updated starter template url

01aae3d

fleboulch reviewed May 17, 2019

View reviewed changes

pmverma closed this May 17, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Use updated API method from main generator to load configs #69

Use updated API method from main generator to load configs #69

pmverma commented May 15, 2019

pmverma commented May 15, 2019

pmverma commented May 15, 2019

mraible commented May 15, 2019

pmverma commented May 15, 2019

fleboulch May 17, 2019 •

edited

pmverma May 17, 2019

Arv18 May 17, 2019

Use updated API method from main generator to load configs #69

Use updated API method from main generator to load configs #69

Conversation

pmverma commented May 15, 2019

pmverma commented May 15, 2019

pmverma commented May 15, 2019

mraible commented May 15, 2019

pmverma commented May 15, 2019

fleboulch May 17, 2019 • edited

Choose a reason for hiding this comment

pmverma May 17, 2019

Choose a reason for hiding this comment

Arv18 May 17, 2019

Choose a reason for hiding this comment

fleboulch May 17, 2019 •

edited