Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support ad hoc celebration date overrides #81

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Conversation

igneus
Copy link
Owner

@igneus igneus commented Mar 7, 2021

fix #80

Church authorities occasionally make an ad hoc change to the calendar, moving a celebration, just for the given year, to a more convenient date beyond the usual calendar rules. This PR proposes one possible way of addressing this.

Shortcomings:

  • as it operates solely on the level of celebration dates, but doesn't otherwise affect the logic of celebration precedence, we still aren't able to compute calendar exactly as ruled in the recent CDW response concerning 2022, since Corpus Christi and Birth of St. John Baptist have exactly the same rank and thus the solemnity receiving first Vespers according to the response doesn't receive them according to calendarium-romanum
  • it is able to move singular celebrations only (but AFAIK ad hoc moving around has so far never affected e.g. a group of optional memorials on the same date, but always a higher-ranking important celebration; should it nevertheless be needed in future, the logic can be extended)

Comments and and alternative proposals welcome.

as a way to make ad hoc changes of both sanctorale and temporale
celebration dates

+ make Temporale#transfer_to_sunday and #extensions public
@igneus igneus changed the title Support ad hoc celebration date overrides [WIP] [WIP] Support ad hoc celebration date overrides Mar 7, 2021
when moving a sanctorale celebration to a new date without replacing the
old date with another celebration
current calendarium-romanum model cannot get this the way expected in
the CDW response
@igneus igneus changed the title [WIP] Support ad hoc celebration date overrides Support ad hoc celebration date overrides Mar 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

June 23-25, 2022 (Sacred Heart & Nativity of St. John the Baptist)
1 participant