Event-based customization of Calendar behaviour #84
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
before I forgot they have a separate rank higher than Rank::PRIMARY
strongly inspired by previous experience with the Symfony EventDispatcher component
+ make Calendar instance available as event attribute + prefix event IDs with `calendar__`
... if they come from Rome and affect the whole church. Other ad hoc changes can be implemented using individual custom event listeners.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an alternative way to fix #80.
I have been considering something like this for a long time - to allow customization of
Calendarbehaviour through events (heavily used in the Symfony PHP framework and elsewhere).Neat advantage of this solution compared to #81 is that it makes it easily possible to grant first Vespers to a celebration which wouldn't receive them per the standard logic of precedence. Most (if not all) other thinkable changes to the calendar logic are possible, some of them in multiple different ways.
Disadvantage is that it's now equally easy to turn a calendar in a complete mess which is hard to read and reason about. (As exemplified by implementation of the Ubi vero S. Ioannes Baptista patronus sit nationis vel dioecesis vel civitatis aut
communitatis religiosae... code example.)