Fix multiple window movement issue #5521
Open
+15
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slyshot
changed the title
slyshot
changed the title
slyshot
force-pushed
the
moving_multiple
branch
2 times, most recently
from
860c930
to
9ccff4c
Compare
slyshot
force-pushed
the
moving_multiple
branch
2 times, most recently
from
db6dc2b
to
ff7be20
Compare
slyshot
force-pushed
the
moving_multiple
branch
3 times, most recently
from
98978e1
to
07bf19d
Compare
slyshot
force-pushed
the
moving_multiple
branch
4 times, most recently
from
5ac043e
to
6f2a85b
Compare
orestisfl
added
the
waiting
|
Converted to a draft since it depends on #5529 |
|
@slyshot please rebase onto |
orestisfl
removed
the
waiting
orestisfl
requested changes
Jul 23, 2023
orestisfl
added
the
waiting
|
Will this be merged? I've been using patch ever since it came out and everything performs like it should. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This solves #5382. The issue is caused because there's no container between the workspace and the windows, and when focus is moved up to the workspace,
tree_movewill refuse to move workspaces.I was planning on making a change elsewhere(Making the split container if they'd otherwise attach to the workspace at all), but as I mentioned in my comment on the issue, the windows attaching directly to the workspace seems specifically intentional based on comments in code. For this reason, making the change at
tree_moveinstead of earlier seems needed to respect that intention. If I'm mistaken in any way, or making the earlier change seems like a good idea anyways, let me know.Thanks.