Refactor suggestions #115

i-like-robots · 2018-01-21T20:04:54Z

This refactors the filtered suggestions into the top-level component so it's not reaching down the component tree to generate its own state.

This also breaks up the key press handler into separate functions out of the component class definition.

coveralls · 2018-01-21T20:08:15Z

Coverage increased (+0.05%) to 99.401% when pulling 9e79421 on refactor-suggestions into a7c014e on 6.0.

i-like-robots added this to the 6.0.0 milestone Jan 21, 2018

i-like-robots mentioned this pull request Jan 21, 2018

V6 #106

Closed

12 tasks

i-like-robots added 3 commits January 21, 2018 20:28

Refactor key handlers into separate functions

26682f7

Refactor filtered suggestions into top-level component

9fa322b

Refactor regexp generators into shared module

4bb0022

i-like-robots force-pushed the refactor-suggestions branch from d31d0f7 to 4bb0022 Compare January 21, 2018 20:47

i-like-robots added 2 commits January 22, 2018 08:36

Re-name 'selected' state 'index'

39ba39c

Refactor up/down key handlers with simple ternary

9e79421

i-like-robots merged commit 64966a0 into 6.0 Jan 22, 2018

i-like-robots deleted the refactor-suggestions branch January 22, 2018 09:31

Provide feedback