Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V6 #106

Closed
12 tasks done
i-like-robots opened this issue Nov 14, 2017 · 11 comments
Closed
12 tasks done

V6 #106

i-like-robots opened this issue Nov 14, 2017 · 11 comments
Milestone

Comments

@i-like-robots
Copy link
Owner

i-like-robots commented Nov 14, 2017

This is a catch-all issue tracking V6 changes and bug fixes.

@mklopets
Copy link

Is there a plan to release this?

@drichar
Copy link

drichar commented Apr 30, 2019

Would love to utilize the custom suggestion component! Will 6.0 be released?

@i-like-robots
Copy link
Owner Author

I've published react-tag-autocomplete@6.0.0-beta.0 to npm, please give it a try and let me know if there are any issues!

@theJian
Copy link

theJian commented May 16, 2019

@i-like-robots Any plan to refactor using Hooks? Maybe starting with examples?

@i-like-robots
Copy link
Owner Author

@theJian No not yet. Starting with the examples sounds like a fine idea though.

@filippofilip95
Copy link

When do you plan to merge this? :)

@i-like-robots
Copy link
Owner Author

Unfortunately I've not received any feedback on the beta release so I have been reluctant to release it. If you would like to try it then there are instructions in the readme 😄 :

https://github.com/i-like-robots/react-tags/tree/6.0#installation

@filippofilip95
Copy link

filippofilip95 commented Aug 23, 2019

Thanks for the quick reply 👍 I've tested it now and it works like charm 😄 Just followed your migration instructions 🥇

Our implementation is minimal. But I can confirm that this works :)

Screen Shot 2019-08-23 at 1 23 08 PM

@coxom
Copy link

coxom commented Mar 2, 2020

When using an async search to fetch the suggestions the component won't work correctly and will get out of sync with the suggestions provided via props.
From the code seems like it's not looking into changes from suggestions to update its internal state.

PS: Seems like the beta version is now the default version installed when you do "npm i react-tag-autocomplete". Took me a while to understand why handleInputChange was not working.

@i-like-robots
Copy link
Owner Author

Thanks for the heads up about incorrect npm distribution tags @coxom, this has been corrected here.

@insekticid
Copy link

insekticid commented Mar 4, 2020

@coxom I solved onInput async fetch with <ReactTags ref={this.tagsRef}
@i-like-robots is this bug?

onInput = (query) => {
            return fetch(`/search/?q=${query}`).then(result => result.json()).then((suggestions) => {
                        this.tagsRef.current.setState({ query, options: suggestions, suggestions });

EDIT: I did some changes and I finally added support for larger result set with scroller enabled and keyUP and Down focused scroller move
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants