Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update redis-pq-demo to use playground examples container #105

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Update redis-pq-demo to use playground examples container #105

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ae0cf05
Update redis-pq-demo to use playground examples container
usingtechnology Oct 25, 2023
19e8c1f
use permalinks for playground
usingtechnology Oct 25, 2023
ba0d11a
just use main for the link to aca-py...
usingtechnology Oct 27, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
22 changes: 11 additions & 11 deletions redis-pq-demo/README.md
View file
Open in desktop
Expand Up @@ -7,9 +7,9 @@ How to see a full fledged demo, and a set of agents using the mediator (with red
To run a redis-cluster and acapy as a mediator with redis for the first time. use the following commands

```
git clone https://github.com/hyperledger/aries-mediator-service.git z
cd redis-pq-demo
cp .\.env.sample .\.env
git clone https://github.com/hyperledger/aries-mediator-service.git
cd aries-mediator-service/redis-pq-demo
cp .env.sample .env
docker-compose -f docker-compose.redis.yml up -d
docker-compose up --build
```
Expand All @@ -18,20 +18,20 @@ After establishing a connection with the mediator. You can inspect the contents

## Example agents

If you want to run a set of agents using the mediator, consider the acapy playground demo.
If you want to run a set of agents using the mediator, consider the acapy [playground](https://github.com/hyperledger/aries-cloudagent-python/tree/f7db243430285edeb721f079ff0694bb76f41a3e/demo/playground) demo.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Necessary to tie it to a commit? Creates technical debt that would be nice to avoid, if possible.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will update, good catch!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It’s there twice :-)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cleaned up with a permalink.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I’m confused. Why are you referencing a commit vs. just referencing the main branch? That’s what I was wondering. Wouldn’t it be safer to just reference main?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

my thinking was that these two projects get out of sync. so at least this sends them to the instructions as they existed when this was updated. however, now that you make me think of it, if the aca-py playground changes then those "old" instructions could be more confusing!... ok will change to point at main.


```
git clone https://github.com/hyperledger/aries-cloudagent-python.git
cd aries-cloudagent-python/demo/playground
cp .env.sample .env
APP_NETWORK_NAME=redis-cluster docker-compose up
APP_NETWORK_NAME=redis_cluster APP_NETWORK_EXTERNAL=true docker-compose up --build
```

There is a python script provided that will connect all the playground's agents using the provided invitation. Retrieve the invitiation url from the start-up logs of the mediator, and use that for MEDIATOR_INVITATION_URL in the following commands.
Along with the playground, there are [examples/tests](https://github.com/hyperledger/aries-cloudagent-python/tree/f7db243430285edeb721f079ff0694bb76f41a3e/demo/playground/examples) that illustrate connecting agents through the mediator and pinging each other. Retrieve the invitiation url from the start-up logs of the mediator, and use that for MEDIATOR_INVITATION_URL in the following commands.

```
cd scripts
pip install -r requirements.txt
<edit the MEDIATOR_INVITATION_URL in mediator_ping_agents.py>
python ./mediator_ping_agents.py
```
<new terminal at aries-cloudagent-python/demo/playground>
cd examples
docker compose build
APP_NETWORK_NAME=redis_cluster docker compose run -e MEDIATOR_INVITATION_URL=https://cd55-207-6-152-178.ngrok.io?c_i=eyJAdHlwZSI6ICJodHRwczovL2RpZGNvbW0ub3JnL2Nvbm5lY3Rpb25zLzEuMC9pbnZpdGF0aW9uIiwgIkBpZCI6ICI4ODI4ZDU4Ni0wMDYzLTRkZDktOTQxNy0wNzJhMGE4NDU0MjIiLCAic2VydmljZUVuZHBvaW50IjogImh0dHBzOi8vY2Q1NS0yMDctNi0xNTItMTc4Lm5ncm9rLmlvIiwgInJlY2lwaWVudEtleXMiOiBbIkYxdThXc1JkN2V5VEx6YTFzdEpubmpzeFl3eEwxTW1kWmVMdGdQUEppSmdhIl0sICJsYWJlbCI6ICJNZWRpYXRvciJ9 tests -s
```