Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update redis-pq-demo to use playground examples container #105

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

usingtechnology
Copy link
Contributor

See aries-cloudagent-python issue 2555...

Update documentation for redis-pq-demo to use the changes in ACA-Py playground demo.

Fixes #104

Signed-off-by: Jason Sherman <tools@usingtechnolo.gy>
@@ -18,20 +18,20 @@ After establishing a connection with the mediator. You can inspect the contents

## Example agents

If you want to run a set of agents using the mediator, consider the acapy playground demo.
If you want to run a set of agents using the mediator, consider the acapy [playground](https://github.com/hyperledger/aries-cloudagent-python/tree/f7db243430285edeb721f079ff0694bb76f41a3e/demo/playground) demo.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Necessary to tie it to a commit? Creates technical debt that would be nice to avoid, if possible.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will update, good catch!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It’s there twice :-)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cleaned up with a permalink.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I’m confused. Why are you referencing a commit vs. just referencing the main branch? That’s what I was wondering. Wouldn’t it be safer to just reference main?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

my thinking was that these two projects get out of sync. so at least this sends them to the instructions as they existed when this was updated. however, now that you make me think of it, if the aca-py playground changes then those "old" instructions could be more confusing!... ok will change to point at main.

remove explicit example of mediator invitation url

Signed-off-by: Jason Sherman <tools@usingtechnolo.gy>
Signed-off-by: Jason Sherman <tools@usingtechnolo.gy>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update redis-pq-demo notes on acapy playground
3 participants