Basic webpack setup #176
Basic webpack setup #176
Conversation
pgerochi
commented
Oct 19, 2017
pgerochi
commented
- basic version of webpack.
- I need a few suggestion here, this is only the bare bones of what should be in webpack. Right now it: compiles css, minifies js. Anyone else have a suggestion on what we can add? @oriSomething
pgerochi
changed the title
| @@ -115,30 +115,27 @@ | |||
| } | |||
| ], | |||
| "scripts": { | |||
| "modernizr": "gulp modernizr" | |||
| "modernizr": "cd node_modules/modernizr && ./bin/modernizr -c lib/config-all.json && mv ./modernizr.js ../../src/js/lib/modernizr.js", | |||
There was a problem hiding this comment.
Regression to Issue #174 . modernizr script should handled by webpack rather than shell script to prevent OS incompatibilities
Feature/html5blank webpack
pgerochi
changed the title
|
@lregla - are you comfortable with this pull request to merge? |
|
@pgerochi I would like to do some further testing on one of the sites I have in production using this theme. I wouldn't be able to get to that until later in the week given my current schedule. |
# Conflicts: # src/functions.php
… feature/html5blank-webpack
|
Subscribing :) |
|
I might just not understand the blend of Webpack with WP, but... |
|
@chancesmith yes you're right. i'm currently testing this out for a project and i found that i've taken wp_enqueue_script() out . one other thing is that I haven't set up relative image links in css with webpack on this branch. If you'd like to help out, please feel free. |
