New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/html5blank webpack #177

Merged

pgerochi merged 3 commits into html5blank:feature/html5blank-webpack from lregla:feature/html5blank-webpack

Oct 20, 2017

Contributor

lregla commented Oct 20, 2017

I took some time to clone your feature branch in PR #176 into my local environment and try it out. Sending you a few helpful (hopefully) edits.

Edited webpack config to pattern the output paths after the original gulp configuration (makes a 'dist' directory)
When first pulling in the feature branch I was getting a webpack error and found it was fixed when I deleted the package-lock file. So I added package-lock to .gitignore
Also removed the generated bundle.js file from the checked in code.

lregla added 3 commits

October 19, 2017 20:53


          removed webpack compiled output file from codebase for cleanup purposes

b2982cc


          modified webpack configuration to deploy code to 'dist' directory con…

642db53

…sistent with previous gulp configuration


          removed generated package-lock file from code, added to gitignore

49f80d8

pgerochi merged commit cc1ad20 into html5blank:feature/html5blank-webpack

Member

pgerochi commented Oct 20, 2017

@lregla thanks for this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment