add missing search page, properly link it #50
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fangerer
approved these changes
Mar 20, 2024
Comment on lines
+679
to
+683
| from nikola import filters | ||
|
|
||
| FILTERS = { | ||
| ".html": [filters.add_header_permalinks], | ||
| } |
There was a problem hiding this comment.
This introduced a visual regression:
After this PR:
Before this PR:
Search works fine without the permalinks; consider removing them for less visual clutter.
There was a problem hiding this comment.
Perhaps we can just style them better? Being able to link to subheadings on pages is nice.
There was a problem hiding this comment.
Sure, that would be a nice solution. I'll create an issue for it, so it's not forgotten :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #48
I guess no one ever checked that search was working? Weird.