Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Visual regression after gh-50 enabled permalinks for all headers #51

Closed
erlend-aasland opened this issue Mar 22, 2024 · 2 comments · Fixed by #52
Closed

Visual regression after gh-50 enabled permalinks for all headers #51

erlend-aasland opened this issue Mar 22, 2024 · 2 comments · Fixed by #52

Comments

@erlend-aasland
Copy link
Contributor

erlend-aasland commented Mar 22, 2024

#50 introduced a visual regression.

After #50:
Screenshot 2024-03-22 at 00 40 21

Before #50:
Screenshot 2024-03-22 at 00 40 43

See also:

@erlend-aasland
Copy link
Contributor Author

@hodgestar #50 (comment):

Perhaps we can just style them better? Being able to link to subheadings on pages is nice.

@mattip
Copy link
Contributor

mattip commented Mar 22, 2024

Thanks for pointing it out. I only did half the sync with the pypy/pypy.org site styling, #52 should make it look better.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants