-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: hover placeholder transition for smartenvinput #4006
Closed
Closed
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
cf37fbd
feat: hover placeholder transition for smartenvinput
nivedin 5bac622
chore: update URL input
nivedin e6e300c
chore: add fallback url if endpoint is empty while saving and sharing…
nivedin 8fd6b2f
chore: update default tab to have empty endpoint
nivedin 10cb900
fix: revert text update in envinput for empty state
nivedin 0c993d0
chore: add i18n and readonly to envinput
nivedin 05ad84f
chore: add fallback url and add reqIndex for graphql saving
nivedin 7411e36
chore: remove readonly type
nivedin File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -86,6 +86,8 @@ import { platform } from "~/platform" | |
import { useService } from "dioc/vue" | ||
import { RESTTabService } from "~/services/tab/rest" | ||
import { GQLTabService } from "~/services/tab/graphql" | ||
import { getDefaultRESTRequest } from "~/helpers/rest/default" | ||
import { getDefaultGQLRequest } from "~/helpers/graphql/default" | ||
|
||
const t = useI18n() | ||
const toast = useToast() | ||
|
@@ -221,6 +223,15 @@ const saveRequestAs = async () => { | |
|
||
requestUpdated.name = requestName.value | ||
|
||
if (props.mode === "rest") { | ||
;(requestUpdated as HoppRESTRequest).endpoint = | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Please resolve type issues here |
||
(requestUpdated as HoppRESTRequest).endpoint || | ||
getDefaultRESTRequest().endpoint | ||
} else { | ||
;(requestUpdated as HoppGQLRequest).url = | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. There are type issues here which needs to be resolved. |
||
(requestUpdated as HoppGQLRequest).url || getDefaultGQLRequest().url | ||
} | ||
|
||
if (picked.value.pickedType === "my-collection") { | ||
if (!isHoppRESTRequest(requestUpdated)) | ||
throw new Error("requestUpdated is not a REST Request") | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we rename the placeholder to
Enter a URL or Paste cURL Command
? Because many users don't know that we can directly paste the cURL command. So, explicitly mentioning that would help usersThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wow. I don't know about this feature. It's cool. Agree with @anwarulislam