feat: hover placeholder transition for smartenvinput #4006
Conversation
nivedin
requested review from
AndrewBastin,
amk-dev and
anwarulislam
as code owners
nivedin
force-pushed
the
feat/app-experiment-animation
branch
from
0802c5d
to
7411e36
Compare
| "header_list": "Header List", | ||
| "http_placeholder":"Enter a URL or cURL command", |
There was a problem hiding this comment.
Can we rename the placeholder to Enter a URL or Paste cURL Command? Because many users don't know that we can directly paste the cURL command. So, explicitly mentioning that would help users
There was a problem hiding this comment.
Wow. I don't know about this feature. It's cool. Agree with @anwarulislam
There was a problem hiding this comment.
@nivedin In the GQL tab, when connecting to the default url, the color of the URL becomes extremely dim and isn't readable. Also, the input should be disabled when connected.
Is it possible to bring back a bright color to the default endpoint/url when a user sends a request/connects to it?
Screen.Recording.2024-04-26.at.7.12.52.PM.mov
| @@ -109,6 +114,7 @@ const props = withDefaults( | |||
| contextMenuEnabled?: boolean | |||
| secret?: boolean | |||
| autoCompleteEnv?: boolean | |||
| placeholderHoverString: string | |||
There was a problem hiding this comment.
There are many instances where EnvInput is used without a placeholderHoverString. So this should not be a required prop.
| @@ -221,6 +223,15 @@ const saveRequestAs = async () => { | |||
|
|
|||
| requestUpdated.name = requestName.value | |||
|
|
|||
| if (props.mode === "rest") { | |||
| ;(requestUpdated as HoppRESTRequest).endpoint = | |||
There was a problem hiding this comment.
Please resolve type issues here
| (requestUpdated as HoppRESTRequest).endpoint || | ||
| getDefaultRESTRequest().endpoint | ||
| } else { | ||
| ;(requestUpdated as HoppGQLRequest).url = |
There was a problem hiding this comment.
There are type issues here which needs to be resolved.
Closes HFE-482
Description
This PR adds placeholder hover transition effect on request URL input on both REST and GraphQl section
Screen.Recording.2024-04-24.at.9.04.44.PM.mov
Checks