Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: oauth revamp + support for multiple grant types in oauth #3885

Merged
merged 27 commits into from Mar 19, 2024

Conversation

amk-dev
Copy link
Contributor

@amk-dev amk-dev commented Mar 9, 2024

This PR introduces support for the following oauth grant types.

  • Authorization Code
  • Authorization Code + PKCE
  • Client Credentials
  • Password
  • Implicit

@VVelox
Copy link

VVelox commented Mar 10, 2024

This actually going to get accepted, I wonder, given the fate of #3266 ?

@amk-dev amk-dev marked this pull request as ready for review March 11, 2024 01:35
Copy link
Member

@jamesgeorge007 jamesgeorge007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • All Grant Types require a Pass by field to indicate whether to include OAuth data as part of request headers/URL.

  • There's an exception while opting for OAuth 2.0 as the Authorization Type for a GraphQL request.

    image

    Screen.Recording.2024-03-11.at.7.46.42.PM.mov
  • The fields for Basic Auth & Bearer Token Authorization types aren't displayed. Applicable to the modal aimed at setting authorization at the collection level.

    Screen.Recording.2024-03-11.at.8.00.47.PM.mov

@jamesgeorge007 jamesgeorge007 force-pushed the feat/oauth-revamp branch 7 times, most recently from b490c3c to 7bd4692 Compare March 14, 2024 19:10
Copy link
Member

@jamesgeorge007 jamesgeorge007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀
There's an issue persisting, about a mismatch in schema while saving the state in the modal for setting authorization/headers at the collection level. A fix for the same is landed on the release branch and should be resolved along with the rebase.

packages/hoppscotch-data/src/rest/v/2.ts Outdated Show resolved Hide resolved
Copy link
Member

@nivedin nivedin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 💯

@AndrewBastin AndrewBastin merged commit 6b58915 into hoppscotch:release/2024.3.0 Mar 19, 2024
1 check passed
@amk-dev amk-dev mentioned this pull request Mar 20, 2024
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants