New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: oauth revamp + support for multiple grant types in oauth #3885
feat: oauth revamp + support for multiple grant types in oauth #3885
Conversation
This actually going to get accepted, I wonder, given the fate of #3266 ? |
d08d21a
to
0e12233
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
-
All Grant Types require a
Pass by
field to indicate whether to include OAuth data as part of request headers/URL. -
There's an exception while opting for
OAuth 2.0
as the Authorization Type for a GraphQL request.Screen.Recording.2024-03-11.at.7.46.42.PM.mov
-
The fields for
Basic Auth
&Bearer Token
Authorization types aren't displayed. Applicable to the modal aimed at setting authorization at the collection level.Screen.Recording.2024-03-11.at.8.00.47.PM.mov
packages/hoppscotch-common/src/components/collections/Properties.vue
Outdated
Show resolved
Hide resolved
packages/hoppscotch-common/src/components/collections/graphql/Folder.vue
Outdated
Show resolved
Hide resolved
packages/hoppscotch-common/src/services/persistence/__tests__/__mocks__/index.ts
Outdated
Show resolved
Hide resolved
b490c3c
to
7bd4692
Compare
packages/hoppscotch-common/src/components/collections/Properties.vue
Outdated
Show resolved
Hide resolved
1db467a
to
f485e9c
Compare
809b397
to
2e1ec17
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
There's an issue persisting, about a mismatch in schema while saving the state in the modal for setting authorization/headers at the collection level. A fix for the same is landed on the release branch and should be resolved along with the rebase.
88e0ade
to
2686603
Compare
Account for active GQL tabs while setting the received token.
…arams Adds a new `Pass by` field.
…rved while redirecting back
… while redirected back
…ad of hardcoded values
Update fixtures.
e039609
to
f6f758c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 💯
This PR introduces support for the following oauth grant types.