Skip to content

Commit

Permalink
chore: clean up unwanted comments
Browse files Browse the repository at this point in the history
  • Loading branch information
amk-dev committed Mar 15, 2024
1 parent 7cb05d2 commit 1db467a
Show file tree
Hide file tree
Showing 6 changed files with 2 additions and 11 deletions.
Expand Up @@ -128,10 +128,8 @@
:shortcut="['P']"
@click="
() => {
debugger
emit('edit-properties', {
collectionIndex: collectionIndex,
// AM-REMINDER: check this line, because collection is not defined anywhere
collection: collection,
})
hide()
Expand Down
Expand Up @@ -667,7 +667,6 @@ const inheritedProperties = computed(() => {
const computedAuthHeader = getComputedAuthHeaders(
request.value,
// AM-COMMENT: look into this, GQLAuth not yet updated yet issue
props.inheritedProperties.auth.inheritedAuth
)[0]
Expand Down
1 change: 0 additions & 1 deletion packages/hoppscotch-common/src/components/http/Headers.vue
Expand Up @@ -619,7 +619,6 @@ const inheritedProperties = computed(() => {
const computedAuthHeader = getComputedAuthHeaders(
aggregateEnvs.value,
request.value,
// AM-COMMENT: check this line, this is because the GqlAuth is not updated yet to use the updated auth type
props.inheritedProperties.auth.inheritedAuth,
false
)[0]
Expand Down
1 change: 0 additions & 1 deletion packages/hoppscotch-common/src/helpers/RequestRunner.ts
Expand Up @@ -247,7 +247,6 @@ export function runRESTRequest$(
combineEnvVariables(finalEnvs)
)

// AM-COMMENT: check this, this is due to the GqlAuth not updated yet, revist after GqlAuth is updated
const effectiveRequest = getEffectiveRESTRequest(finalRequest, {
id: "env-id",
v: 1,
Expand Down
1 change: 0 additions & 1 deletion packages/hoppscotch-common/src/pages/import.vue
Expand Up @@ -79,7 +79,6 @@ const importCollections = (url: unknown, type: unknown) =>
content.data,
TO.fromPredicate(isOfType("string")),
TE.fromTaskOption(() => IMPORTER_INVALID_FILE_FORMAT),
// AM-COMMENT: ask james if this got introduced in any of the multiple import PRs
TE.chain((data) => importer.importer(data))
)
)
Expand Down
Expand Up @@ -25,7 +25,6 @@ export const REST_COLLECTIONS_MOCK: HoppCollection[] = [
folders: [],
requests: [
{
// AM-COMMENT: check this
v: "3",
endpoint: "https://echo.hoppscotch.io",
name: "Echo test",
Expand All @@ -51,7 +50,7 @@ export const GQL_COLLECTIONS_MOCK: HoppCollection[] = [
folders: [],
requests: [
{
v: 2,
v: 3,
name: "Echo test",
url: "https://echo.hoppscotch.io/graphql",
headers: [],
Expand Down Expand Up @@ -139,7 +138,6 @@ export const REST_HISTORY_MOCK: RESTHistoryEntry[] = [
preRequestScript: "",
testScript: "",
requestVariables: [],
// AM-COMMENT: check this
v: "3",
},
responseMeta: { duration: 807, statusCode: 200 },
Expand Down Expand Up @@ -173,7 +171,7 @@ export const GQL_TAB_STATE_MOCK: PersistableTabState<HoppGQLDocument> = {
tabID: "5edbe8d4-65c9-4381-9354-5f1bf05d8ccc",
doc: {
request: {
v: 2,
v: 3,
name: "Untitled",
url: "https://echo.hoppscotch.io/graphql",
headers: [],
Expand All @@ -196,7 +194,6 @@ export const REST_TAB_STATE_MOCK: PersistableTabState<HoppRESTDocument> = {
tabID: "e6e8d800-caa8-44a2-a6a6-b4765a3167aa",
doc: {
request: {
// AM-COMMENT: check this
v: "3",
endpoint: "https://echo.hoppscotch.io",
name: "Echo test",
Expand Down

0 comments on commit 1db467a

Please sign in to comment.