Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update blog posts with instructions to deploy prometheus-operator, to… #348

Open
wants to merge 1 commit into
base: pages
Choose a base branch
from

Conversation

objectiser
Copy link
Contributor

… explain that no longer required

@objectiser
Copy link
Contributor Author

@theute @pilhuhn Have added a note block to indicate prom-operator no longer required - or would it be better to update the instructions to no longer refers to it?

@pilhuhn
Copy link
Member

pilhuhn commented Nov 16, 2017

I think what is a bit problematic is that there is the note and then 2 lines in the code block (without comment on the line) where people may just copy&paste those.
But then I guess it does no harm if prom-operator is deployed either.

But then those are blog posts with a date, so the note may just be fine. For documentation (not blog) I'd say remove the problematic line.

@objectiser
Copy link
Contributor Author

+1 documentation should not reference prom-operator.

So is it ok to merge as is?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants