structs: Fix job canonicalization for array type fields #20522
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Hey @myszon, thanks for the contribution! I think it makes sense. Like you mention in #20497 it's a bit of an edge case, but a bug nonetheless and we appreciate the fix.
I only had some minor wording comments, feel free to accept or reject them. Could you add a changelog entry, though? A textfile inside the .changelog directory with the PR number as the filename and a short description of the fix, have a look at an example. Body of the changelog can be something like:
structs: Fixed job canonicalization for array type fields
and you can also use the make cl command to generate the file. Thanks again!
pkazmierczak
added
backport/1.5.x
pkazmierczak
changed the title
…sks copying returns a value which is equivalent to the canonicalized one.
Co-authored-by: Piotr Kazmierczak <470696+pkazmierczak@users.noreply.github.com>
myszon
force-pushed
the
fix-canonicalize-bug
branch
from
5dfae32
to
8c2400e
Compare
|
Thanks for the comments, accepted suggestions and added the changelog entry. |
pkazmierczak
approved these changes
May 16, 2024
This was referenced May 16, 2024
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #20497