Skip to content

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history
Co-authored-by: Piotr Kazmierczak <470696+pkazmierczak@users.noreply.github.com>
  • Loading branch information
myszon and pkazmierczak committed May 16, 2024
1 parent 7939860 commit 5dfae32
Showing 1 changed file with 9 additions and 9 deletions.
18 changes: 9 additions & 9 deletions nomad/structs/structs_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -791,9 +791,9 @@ func TestJob_Canonicalize(t *testing.T) {

for _, c := range cases {
c.job.Canonicalize()
kopy := c.job.Copy()
if !reflect.DeepEqual(c.job, kopy) {
t.Fatalf("Canonicalize() returned a Job that changed after copy; before %#v; after %#v", c.job, kopy)
copied := c.job.Copy()
if !reflect.DeepEqual(c.job, copied) {
t.Fatalf("Canonicalize() returned a Job that changed after copy; before %#v; after %#v", c.job, copied)
}
}
}
Expand Down Expand Up @@ -2037,9 +2037,9 @@ func TestTaskGroup_Canonicalize(t *testing.T) {

for _, c := range cases {
c.tg.Canonicalize(job)
kopy := c.tg.Copy()
if !reflect.DeepEqual(c.tg, kopy) {
t.Fatalf("Canonicalize() returned a TaskGroup that changed after copy; before %#v; after %#v", c.tg, kopy)
copied := c.tg.Copy()
if !reflect.DeepEqual(c.tg, copied) {
t.Fatalf("Canonicalize() returned a TaskGroup that changed after copy; before %#v; after %#v", c.tg, copied)
}
}
}
Expand Down Expand Up @@ -2248,9 +2248,9 @@ func TestTask_Canonicalize(t *testing.T) {

for _, c := range cases {
c.task.Canonicalize(job, tg)
kopy := c.task.Copy()
if !reflect.DeepEqual(c.task, kopy) {
t.Fatalf("Canonicalize() returned a Task that changed after copy; before %#v; after %#v", c.task, kopy)
copied := c.task.Copy()
if !reflect.DeepEqual(c.task, copied) {
t.Fatalf("Canonicalize() returned a Task that changed after copy; before %#v; after %#v", c.task, copied)
}
}
}
Expand Down

0 comments on commit 5dfae32

Please sign in to comment.