New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: consistent naming of Gradle configuration files / Gradle updates #12997
base: develop
Are you sure you want to change the base?
Conversation
Node: HAPI Test (Restart) Results2 tests 2 ✅ 7m 59s ⏱️ Results for commit dd76e88. ♻️ This comment has been updated with latest results. |
Node: HAPI Test (Node Death Reconnect) Results2 tests 2 ✅ 8m 47s ⏱️ Results for commit dd76e88. ♻️ This comment has been updated with latest results. |
Node: HAPI Test (Token) Results237 tests 235 ✅ 22m 41s ⏱️ Results for commit dd76e88. ♻️ This comment has been updated with latest results. |
Node: HAPI Test (Crypto) Results335 tests 335 ✅ 40m 26s ⏱️ Results for commit dd76e88. ♻️ This comment has been updated with latest results. |
Node: HAPI Test (Misc) Results468 tests 458 ✅ 41m 13s ⏱️ Results for commit dd76e88. ♻️ This comment has been updated with latest results. |
Node: HAPI Test (Time Consuming) Results21 tests 21 ✅ 53m 45s ⏱️ Results for commit dd76e88. ♻️ This comment has been updated with latest results. |
Node: Unit Test Results 2 308 files ±0 2 308 suites ±0 2h 35m 28s ⏱️ + 34m 32s Results for commit dd76e88. ± Comparison against base commit 0e8eca1. This pull request removes 4009 and adds 3772 tests. Note that renamed tests count towards both.
♻️ This comment has been updated with latest results. |
Node: HAPI Test (Smart Contract) Results604 tests 604 ✅ 1h 13m 41s ⏱️ Results for commit dd76e88. ♻️ This comment has been updated with latest results. |
gradle/plugins/src/main/kotlin/com.hedera.gradlebuild.jpms-modules.gradle.kts
Outdated
Show resolved
Hide resolved
gradle/plugins/src/main/kotlin/com.hedera.gradlebuild.root.gradle.kts
Outdated
Show resolved
Hide resolved
gradle/plugins/src/main/kotlin/com.hedera.gradlebuild.jpms-modules.gradle.kts
Outdated
Show resolved
Hide resolved
a1f3c08
to
a0941f3
Compare
Signed-off-by: Jendrik Johannes <jendrik.johannes@gmail.com>
hashgraph/hedera-services#12997 Signed-off-by: Jendrik Johannes <jendrik.johannes@gmail.com>
hashgraph/hedera-services#12997 Signed-off-by: Jendrik Johannes <jendrik.johannes@gmail.com>
hashgraph/hedera-services#12997 Signed-off-by: Jendrik Johannes <jendrik.johannes@gmail.com>
a0941f3
to
156e628
Compare
156e628
to
4b35ea3
Compare
Signed-off-by: Jendrik Johannes <jendrik.johannes@gmail.com>
Signed-off-by: Jendrik Johannes <jendrik.johannes@gmail.com>
d0c3d8a
to
fd043d1
Compare
@JeffreyDallas I cleaned up the PR and move some changes in documentation out of this one. Now there are no other approvals required. Could you re-approve? |
b2a6d3e
to
cc4e9b7
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #12997 +/- ##
=============================================
- Coverage 61.76% 61.74% -0.02%
- Complexity 31236 31246 +10
=============================================
Files 3442 3446 +4
Lines 141226 141291 +65
Branches 14775 14779 +4
=============================================
+ Hits 87222 87235 +13
- Misses 50119 50170 +51
- Partials 3885 3886 +1 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Jendrik Johannes <jendrik.johannes@gmail.com>
Signed-off-by: Jendrik Johannes <jendrik.johannes@gmail.com>
d8be1ac
to
dd76e88
Compare
Description:
Consistent names and locations for shared Gradle configuration (aka convention plugins). Changes:
build-source
tograldle/plugins
and merged to just one "plugins" project. This is what most projects do now. And I like that it keeps things you do not need to touch regularly hidden in the "gradle" folder (that we already have for the wrapper).com.hedera.gradle
namespace to indicate that these are "packages" for the "gradle build configurations" (and not production or test code). The idea is that the configuration (with the same naming) can be reused in other repos like pbj or hedera-sdk-java.com.hedera.gradle.platform
com.hedera.gradle.services
com.hedera.gradle.blocknode
-convention
suffix has been removed from all places where it was used. It was inconsistently used and does not add any value imo.com.hedera.gradle.jpms-modules
is now expressed in a more compact way using the new features for this of theorg.gradlex.jvm-dependency-conflict-resolution
plugin.Related issue(s):
#11568
Notes for reviewer:
Checklist