build: automate publishing to Maven Central #11731

jjohannes · 2024-02-26T10:57:35Z

Description:

Fully automate publishing to Maven Central (by utilizing https://github.com/gradle-nexus/publish-plugin)
Publish all Modules of services (hedera-node)
Publish all Modules of storage (block-node)

As a side effect, assemble and qualityGate now also build the Javadoc and find Javadoc errors.
This PR fixes the errors that were found.

Note: new/reworked convention plugin files follow the naming pattern that will be used consistently with #12997

Related issue(s):

Fixes #11237

Notes for reviewer:

Checklist

Documented (Code comments, README, etc.)
Tested (unit, integration, etc.)

github-actions · 2024-02-26T11:34:56Z

Node: HAPI Test (Restart) Results

2 tests 2 ✅ 5m 23s ⏱️
2 suites 0 💤
2 files 0 ❌

Results for commit b7c3977.

♻️ This comment has been updated with latest results.

github-actions · 2024-02-26T11:37:21Z

Node: HAPI Test (Node Death Reconnect) Results

2 tests 2 ✅ 6m 55s ⏱️
2 suites 0 💤
2 files 0 ❌

Results for commit b7c3977.

♻️ This comment has been updated with latest results.

github-actions · 2024-02-26T11:47:58Z

Node: HAPI Test (Token) Results

235 tests 233 ✅ 19m 20s ⏱️
17 suites 2 💤
17 files 0 ❌

Results for commit b7c3977.

♻️ This comment has been updated with latest results.

github-actions · 2024-02-26T11:53:56Z

Node: HAPI Test (Crypto) Results

335 tests 335 ✅ 42m 45s ⏱️
25 suites 0 💤
25 files 0 ❌

Results for commit b7c3977.

♻️ This comment has been updated with latest results.

github-actions · 2024-02-26T11:56:06Z

Node: E2E Test Results

    1 files     1 suites 25m 26s ⏱️
311 tests 311 ✔️ 0 💤 0 ❌
333 runs 333 ✔️ 0 💤 0 ❌

Results for commit c4310bf.

♻️ This comment has been updated with latest results.

github-actions · 2024-02-26T12:09:42Z

Node: HAPI Test (Misc) Results

459 tests 449 ✅ 43m 49s ⏱️
77 suites 10 💤
77 files 0 ❌

Results for commit b7c3977.

♻️ This comment has been updated with latest results.

github-actions · 2024-02-26T12:24:52Z

Node: HAPI Test (Time Consuming) Results

21 tests 21 ✅ 54m 30s ⏱️
3 suites 0 💤
3 files 0 ❌

Results for commit b7c3977.

♻️ This comment has been updated with latest results.

github-actions · 2024-02-26T12:28:07Z

Node: HAPI Test (Smart Contract) Results

592 tests 592 ✅ 1h 19m 1s ⏱️
63 suites 0 💤
63 files 0 ❌

Results for commit b7c3977.

♻️ This comment has been updated with latest results.

github-actions · 2024-02-26T12:39:13Z

Node: Integration Test Results

    5 files     5 suites 1h 6m 34s ⏱️
322 tests 322 ✔️ 0 💤 0 ❌
333 runs 333 ✔️ 0 💤 0 ❌

Results for commit c4310bf.

♻️ This comment has been updated with latest results.

github-actions · 2024-02-26T13:00:15Z

Node: Unit Test Results

2 280 files ±0 2 280 suites ±0 3h 28m 22s ⏱️ + 1h 8m 50s
118 804 tests +2 118 737 ✅ +2 67 💤 ±0 0 ❌ ±0
127 289 runs +2 127 222 ✅ +2 67 💤 ±0 0 ❌ ±0

Results for commit b7c3977. ± Comparison against base commit 936032a.

This pull request removes 3976 and adds 3741 tests. Note that renamed tests count towards both.


  
             IssuerDN: CN=s-aaaa
            SubjectDN: CN=s-aaaa
           Final Date: Fri Jan 01 00:00:00 UTC 2100
           Public Key: RSA Public Key [2e:28:bc:1e:d3:83:25:92:8e:cb:98:b1:b6:84:06:9c:d5:d8:14:d5],[56:66:d1:a4]
           Start Date: Sat Jan 01 00:00:00 UTC 2000
         SerialNumber: 12482092706667292405
        modulus: c1a0ff5d2372b53d12d12bb87dd03f5e…
        modulus: c1a0ff5d2372b53d12d12bb87dd03f5…
…

com.hedera.node.app.grpc.impl.netty.GrpcServiceBuilderTest ‑ [4] 

com.hedera.node.app.grpc.impl.netty.GrpcServiceBuilderTest ‑ [6] 

com.hedera.node.app.grpc.impl.netty.GrpcServiceBuilderTest ‑ [7]   
  
com.hedera.node.app.service.mono.state.codec.VirtualKeySerdesAdapterTest ‑ [10] com.hedera.node.app.service.mono.state.codec.VirtualBlobKey@dae8ada2
com.hedera.node.app.service.mono.state.codec.VirtualKeySerdesAdapterTest ‑ [11] com.hedera.node.app.service.mono.state.codec.VirtualBlobKey@8304875c
com.hedera.node.app.service.mono.state.codec.VirtualKeySerdesAdapterTest ‑ [12] com.hedera.node.app.service.mono.state.codec.VirtualBlobKey@bdb88569
com.hedera.node.app.service.mono.state.codec.VirtualKeySerdesAdapterTest ‑ [13] com.hedera.node.app.service.mono.state.codec.VirtualBlobKey@40fa07b9
com.hedera.node.app.service.mono.state.codec.VirtualKeySerdesAdapterTest ‑ [14] com.hedera.node.app.service.mono.state.codec.VirtualBlobKey@e15d02d
com.hedera.node.app.service.mono.state.codec.VirtualKeySerdesAdapterTest ‑ [15] com.hedera.node.app.service.mono.state.codec.VirtualBlobKey@5894eee2
com.hedera.node.app.service.mono.state.codec.VirtualKeySerdesAdapterTest ‑ [16] com.hedera.node.app.service.mono.state.codec.VirtualBlobKey@8069ed5
…

♻️ This comment has been updated with latest results.

codecov · 2024-02-26T13:01:10Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 61.80%. Comparing base (f2ac254) to head (fa07dce).
Report is 1 commits behind head on develop.

Additional details and impacted files

@@              Coverage Diff              @@
##             develop   #11731      +/-   ##
=============================================
- Coverage      61.80%   61.80%   -0.01%     
+ Complexity     30620    30619       -1     
=============================================
  Files           3382     3382              
  Lines         138320   138320              
  Branches       14528    14528              
=============================================
- Hits           85488    85485       -3     
- Misses         49133    49136       +3     
  Partials        3699     3699

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

.github/workflows/node-zxc-build-release-artifact.yaml

block-node/blocknode-filesystem-s3/build.gradle.kts

build-logic/project-plugins/src/main/kotlin/com.hedera.hashgraph.blocknode.publish.gradle.kts

Signed-off-by: Jendrik Johannes <jendrik.johannes@gmail.com>

...to make the cross-project 'task.dependsOn' setup working without having to list all projects that are published (again). Signed-off-by: Jendrik Johannes <jendrik.johannes@gmail.com>

Signed-off-by: Jendrik Johannes <jendrik.johannes@gmail.com>

Signed-off-by: Nathan Klick <nathan@swirldslabs.com>

Signed-off-by: Jendrik Johannes <jendrik.johannes@gmail.com>

Signed-off-by: Nathan Klick <nathan@swirldslabs.com>

Neeharika-Sompalli

LGTM from hedera-base

david-bakin-sl

LGTM, only comment I'd like to seen an answer to is why cli-clients isn't published. I don't know the issues - but those are tools useful to developers, so not knowing any reason to say no, I say instead: why not publish them? Let me know.

build-logic/project-plugins/src/main/kotlin/com.hedera.gradle.blocknode-publish.gradle.kts

hedera-node/cli-clients/build.gradle.kts

hedera-node/hedera-evm/build.gradle.kts

Signed-off-by: Jendrik Johannes <jendrik.johannes@gmail.com> Signed-off-by: Nathan Klick <nathan@swirldslabs.com> Co-authored-by: Nathan Klick <nathan@swirldslabs.com> Signed-off-by: Stanimir Stoyanov <stanimir.stoyanov@limechain.tech>

jjohannes requested review from a team as code owners February 26, 2024 10:57

jjohannes requested review from tomzhenghedera and leninmehedy February 26, 2024 10:57

jjohannes changed the title ~~11237 maven central publish~~ build: automate publishing to Maven Centra Feb 26, 2024

jjohannes changed the title ~~build: automate publishing to Maven Centra~~ build: automate publishing to Maven Central Feb 26, 2024

jjohannes self-assigned this Feb 26, 2024

jjohannes force-pushed the 11237-maven-central-publish branch from ec6d615 to 4b8c6e3 Compare February 26, 2024 11:09

jjohannes requested review from tinker-michaelj and a team as code owners February 26, 2024 11:09

jjohannes requested review from quiet-node and iwsimon February 26, 2024 11:09

jjohannes force-pushed the 11237-maven-central-publish branch from 4b8c6e3 to fa07dce Compare February 26, 2024 11:10

jjohannes requested a review from nathanklick February 26, 2024 15:27

jjohannes commented Feb 29, 2024

View reviewed changes

.github/workflows/node-zxc-build-release-artifact.yaml Show resolved Hide resolved

jjohannes commented Feb 29, 2024

View reviewed changes

block-node/blocknode-filesystem-s3/build.gradle.kts Outdated Show resolved Hide resolved

jjohannes commented Feb 29, 2024

View reviewed changes

build-logic/project-plugins/src/main/kotlin/com.hedera.hashgraph.blocknode.publish.gradle.kts Outdated Show resolved Hide resolved

jjohannes force-pushed the 11237-maven-central-publish branch from 86fcb32 to fc3ed2c Compare April 30, 2024 07:32

jjohannes force-pushed the 11237-maven-central-publish branch from fc3ed2c to cf98943 Compare May 7, 2024 13:05

nathanklick approved these changes May 10, 2024

View reviewed changes

jjohannes and others added 10 commits May 10, 2024 10:53

Use 'nexus-publish' plugin to automate Maven Central releases

ab4c133

Signed-off-by: Jendrik Johannes <jendrik.johannes@gmail.com>

Publish all modules and consistently name convention plugins

a58c547

Signed-off-by: Jendrik Johannes <jendrik.johannes@gmail.com>

Add 'releaseMavenCentral' lifecycle task everywhere

f77f1dc

...to make the cross-project 'task.dependsOn' setup working without having to list all projects that are published (again). Signed-off-by: Jendrik Johannes <jendrik.johannes@gmail.com>

Fix Javadoc errors

941bc7c

Signed-off-by: Jendrik Johannes <jendrik.johannes@gmail.com>

fix: resolve merge issues

7107455

Signed-off-by: Nathan Klick <nathan@swirldslabs.com>

fix: retain existing evm artifact coordinates

46e2307

Signed-off-by: Nathan Klick <nathan@swirldslabs.com>

fix: resolve spotless findings

5d92df2

Signed-off-by: Nathan Klick <nathan@swirldslabs.com>

chore: Remove duplicated license header and unnecessary imports

6da219c

Signed-off-by: Jendrik Johannes <jendrik.johannes@gmail.com>

fix: Rename 'org.hedera.evm' modules to follow what is already published

5fa93e8

Signed-off-by: Jendrik Johannes <jendrik.johannes@gmail.com>

chore: name convention plugins to be consistent with #12997

b745a86

Signed-off-by: Jendrik Johannes <jendrik.johannes@gmail.com>

nathanklick force-pushed the 11237-maven-central-publish branch from cf98943 to b745a86 Compare May 10, 2024 15:53

nathanklick previously approved these changes May 10, 2024

View reviewed changes

build: resolve failures due to a new project

b7c3977

Signed-off-by: Nathan Klick <nathan@swirldslabs.com>

nathanklick dismissed their stale review via b7c3977 May 10, 2024 16:26

nathanklick approved these changes May 10, 2024

View reviewed changes

Nana-EC requested review from david-bakin-sl and removed request for quiet-node May 10, 2024 18:01

jeromy-cannon approved these changes May 10, 2024

View reviewed changes

Neeharika-Sompalli approved these changes May 10, 2024

View reviewed changes

kimbor approved these changes May 10, 2024

View reviewed changes

david-bakin-sl approved these changes May 10, 2024

View reviewed changes

build-logic/project-plugins/src/main/kotlin/com.hedera.gradle.blocknode-publish.gradle.kts Show resolved Hide resolved

hedera-node/cli-clients/build.gradle.kts Show resolved Hide resolved

hedera-node/hedera-evm/build.gradle.kts Show resolved Hide resolved

kimbor mentioned this pull request May 10, 2024

fix: fix javadoc errors #13220

Merged

jjohannes merged commit 9f5c168 into develop May 13, 2024
44 of 46 checks passed

jjohannes deleted the 11237-maven-central-publish branch May 13, 2024 05:58

jjohannes mentioned this pull request May 13, 2024

build: remove 'publish EVM' step from GH pipeline #13228

Merged

2 tasks

nathanklick mentioned this pull request May 20, 2024

Resolve release pipeline job dependency error #13420

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

build: automate publishing to Maven Central #11731

build: automate publishing to Maven Central #11731

jjohannes commented Feb 26, 2024 •

edited

github-actions bot commented Feb 26, 2024 •

edited

github-actions bot commented Feb 26, 2024 •

edited

github-actions bot commented Feb 26, 2024 •

edited

github-actions bot commented Feb 26, 2024 •

edited

github-actions bot commented Feb 26, 2024 •

edited

github-actions bot commented Feb 26, 2024 •

edited

github-actions bot commented Feb 26, 2024 •

edited

github-actions bot commented Feb 26, 2024 •

edited

github-actions bot commented Feb 26, 2024 •

edited

github-actions bot commented Feb 26, 2024 •

edited

codecov bot commented Feb 26, 2024 •

edited

Neeharika-Sompalli left a comment

david-bakin-sl left a comment

build: automate publishing to Maven Central #11731

build: automate publishing to Maven Central #11731

Conversation

jjohannes commented Feb 26, 2024 • edited

github-actions bot commented Feb 26, 2024 • edited

Node: HAPI Test (Restart) Results

github-actions bot commented Feb 26, 2024 • edited

Node: HAPI Test (Node Death Reconnect) Results

github-actions bot commented Feb 26, 2024 • edited

Node: HAPI Test (Token) Results

github-actions bot commented Feb 26, 2024 • edited

Node: HAPI Test (Crypto) Results

github-actions bot commented Feb 26, 2024 • edited

Node: E2E Test Results

github-actions bot commented Feb 26, 2024 • edited

Node: HAPI Test (Misc) Results

github-actions bot commented Feb 26, 2024 • edited

Node: HAPI Test (Time Consuming) Results

github-actions bot commented Feb 26, 2024 • edited

Node: HAPI Test (Smart Contract) Results

github-actions bot commented Feb 26, 2024 • edited

Node: Integration Test Results

github-actions bot commented Feb 26, 2024 • edited

Node: Unit Test Results

codecov bot commented Feb 26, 2024 • edited

Codecov Report

Neeharika-Sompalli left a comment

Choose a reason for hiding this comment

david-bakin-sl left a comment

Choose a reason for hiding this comment

jjohannes commented Feb 26, 2024 •

edited

github-actions bot commented Feb 26, 2024 •

edited

github-actions bot commented Feb 26, 2024 •

edited

github-actions bot commented Feb 26, 2024 •

edited

github-actions bot commented Feb 26, 2024 •

edited

github-actions bot commented Feb 26, 2024 •

edited

github-actions bot commented Feb 26, 2024 •

edited

github-actions bot commented Feb 26, 2024 •

edited

github-actions bot commented Feb 26, 2024 •

edited

github-actions bot commented Feb 26, 2024 •

edited

github-actions bot commented Feb 26, 2024 •

edited

codecov bot commented Feb 26, 2024 •

edited