Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing logics and validations from services #8157

Merged
merged 17 commits into from
May 7, 2024
Merged

Add missing logics and validations from services #8157

merged 17 commits into from
May 7, 2024

Commits on Apr 12, 2024

  1. Add missing statements 

    Signed-off-by: Zhivko Petkov <zhpetkov9@gmail.com>
    @zhpetkov
    zhpetkov committed Apr 12, 2024
    Configuration menu
    Copy the full SHA
    a09bba0 View commit details
    Browse the repository at this point in the history

  2. Add missing logic 

    Signed-off-by: Zhivko Petkov <zhpetkov9@gmail.com>
    @zhpetkov
    zhpetkov committed Apr 12, 2024
    Configuration menu
    Copy the full SHA
    a8ba8b6 View commit details
    Browse the repository at this point in the history

  3. Add token multiplier 

    Signed-off-by: Zhivko Petkov <zhpetkov9@gmail.com>
    @zhpetkov
    zhpetkov committed Apr 12, 2024
    Configuration menu
    Copy the full SHA
    5d297c5 View commit details
    Browse the repository at this point in the history

Commits on Apr 19, 2024

  1. Merge branch 'main' into add-token-multiplier-in-estimate-crypto-tran… 

    …sfer
    @zhpetkov
    zhpetkov committed Apr 19, 2024
    Configuration menu
    Copy the full SHA
    2687609 View commit details
    Browse the repository at this point in the history

Commits on Apr 22, 2024

  1. Merge branch 'main' into add-missing-statements-in-reason-to-halt-in-… 

    …self-destruct-V38
    @zhpetkov
    zhpetkov committed Apr 22, 2024
    Configuration menu
    Copy the full SHA
    b096bcd View commit details
    Browse the repository at this point in the history

  2. Merge branch 'add-token-multiplier-in-estimate-crypto-transfer' into … 

    …8056-add-missing-logics-and-validations-p1
    @zhpetkov
    zhpetkov committed Apr 22, 2024
    Configuration menu
    Copy the full SHA
    779efd2 View commit details
    Browse the repository at this point in the history

  3. Add more hedera self destruct operation tests and fix acceptance tests 

    Signed-off-by: Zhivko Petkov <zhpetkov9@gmail.com>
    @zhpetkov
    zhpetkov committed Apr 22, 2024
    Configuration menu
    Copy the full SHA
    58761ac View commit details
    Browse the repository at this point in the history

  4. Merge branch 'missing-logic-abstract-logic-create' into 8056-add-miss… 

    …ing-logics-and-validations-p1
    @zhpetkov
    zhpetkov committed Apr 22, 2024
    Configuration menu
    Copy the full SHA
    25d56a5 View commit details
    Browse the repository at this point in the history

  5. Refactor the code and extract the repeating methods in HederaSelfDest… 

    …ructOperationBase

Signed-off-by: Zhivko Petkov <zhpetkov9@gmail.com>
    @zhpetkov
    zhpetkov committed Apr 22, 2024
    Configuration menu
    Copy the full SHA
    6b902db View commit details
    Browse the repository at this point in the history

Commits on Apr 23, 2024

  1. Resolve comments 

    Signed-off-by: Zhivko Petkov <zhpetkov9@gmail.com>
    @zhpetkov
    zhpetkov committed Apr 23, 2024
    Configuration menu
    Copy the full SHA
    55deb6f View commit details
    Browse the repository at this point in the history

  2. Add zero suppliers in AbstractAutoCreationLogic 

    Signed-off-by: Zhivko Petkov <zhpetkov9@gmail.com>
    @zhpetkov
    zhpetkov committed Apr 23, 2024
    Configuration menu
    Copy the full SHA
    448867a View commit details
    Browse the repository at this point in the history

Commits on Apr 24, 2024

  1. Set account max automatic associations properly in AbstractAutoCreati… 

    …onLogic

Signed-off-by: Zhivko Petkov <zhpetkov9@gmail.com>
    @zhpetkov
    zhpetkov committed Apr 24, 2024
    Configuration menu
    Copy the full SHA
    fe8262c View commit details
    Browse the repository at this point in the history

Commits on Apr 30, 2024

  1. Resolve comment for maxAutoAssociations 

    Signed-off-by: Zhivko Petkov <zhpetkov9@gmail.com>
    @zhpetkov
    zhpetkov committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    ea828ae View commit details
    Browse the repository at this point in the history

Commits on May 3, 2024

  1. Add missing logics and validations from services p2 (#8186) 

    PrecompilePricingUtils - computeViewFunctionGas
Change calculate implementation and now will return a larger of minimum or gas charge plus premium. Add new tests and modify old ones.

AllowanceHelpers - fetchOwxnerAccount
ApproveAllowanceLogic - INVALID_ALLOWANCE_SPENDER_ID
Add loadAccountOrFailWith and validateUsable in Store which help to load the account from the state and throw the given code if an exception occurs due to an invalid account. Add new tests and modify old ones.

---------

Signed-off-by: Zhivko Petkov <zhpetkov9@gmail.com>
    @zhpetkov
    zhpetkov committed May 3, 2024
    Configuration menu
    Copy the full SHA
    b718727 View commit details
    Browse the repository at this point in the history

Commits on May 7, 2024

  1. Resolve comments 

    Signed-off-by: Zhivko Petkov <zhpetkov9@gmail.com>
    @zhpetkov
    zhpetkov committed May 7, 2024
    Configuration menu
    Copy the full SHA
    d3fd7c5 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into 8056-add-missing-logics-and-validations-p1 

    Signed-off-by: Zhivko Petkov <119669063+zhpetkov@users.noreply.github.com>
    @zhpetkov
    zhpetkov committed May 7, 2024
    Configuration menu
    Copy the full SHA
    1407149 View commit details
    Browse the repository at this point in the history

  3. Fix self destruct operation test and replaceAliasWithId 

    Signed-off-by: Zhivko Petkov <zhpetkov9@gmail.com>
    @zhpetkov
    zhpetkov committed May 7, 2024
    Configuration menu
    Copy the full SHA
    bd92975 View commit details
    Browse the repository at this point in the history