Add missing logics and validations from services #8157
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Zhivko Petkov <zhpetkov9@gmail.com>
Signed-off-by: Zhivko Petkov <zhpetkov9@gmail.com>
Signed-off-by: Zhivko Petkov <zhpetkov9@gmail.com>
…self-destruct-V38
…8056-add-missing-logics-and-validations-p1
Signed-off-by: Zhivko Petkov <zhpetkov9@gmail.com>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #8157 +/- ##
============================================
+ Coverage 92.28% 92.30% +0.01%
- Complexity 7280 7288 +8
============================================
Files 898 899 +1
Lines 29338 29355 +17
Branches 3575 3583 +8
============================================
+ Hits 27075 27096 +21
+ Misses 1446 1439 -7
- Partials 817 820 +3 ☔ View full report in Codecov by Sentry. |
…ing-logics-and-validations-p1
zhpetkov
requested review from
IvanKavaldzhiev,
kselveliev and
bilyana-gospodinova
zhpetkov
added
enhancement
…ructOperationBase Signed-off-by: Zhivko Petkov <zhpetkov9@gmail.com>
kselveliev
reviewed
Apr 22, 2024
hedera-mirror-web3/src/main/java/com/hedera/services/txns/crypto/AbstractAutoCreationLogic.java
Outdated
Show resolved
Hide resolved
kselveliev
reviewed
Apr 22, 2024
hedera-mirror-web3/src/main/java/com/hedera/services/txns/crypto/AbstractAutoCreationLogic.java
Outdated
Show resolved
Hide resolved
hedera-mirror-web3/src/main/java/com/hedera/services/txns/crypto/AbstractAutoCreationLogic.java
Outdated
Show resolved
Hide resolved
hedera-mirror-web3/src/main/java/com/hedera/services/txns/crypto/AbstractAutoCreationLogic.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Zhivko Petkov <zhpetkov9@gmail.com>
Signed-off-by: Zhivko Petkov <zhpetkov9@gmail.com>
…onLogic Signed-off-by: Zhivko Petkov <zhpetkov9@gmail.com>
hedera-mirror-web3/src/main/java/com/hedera/services/txns/crypto/AbstractAutoCreationLogic.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Zhivko Petkov <zhpetkov9@gmail.com>
PrecompilePricingUtils - computeViewFunctionGas Change calculate implementation and now will return a larger of minimum or gas charge plus premium. Add new tests and modify old ones. AllowanceHelpers - fetchOwxnerAccount ApproveAllowanceLogic - INVALID_ALLOWANCE_SPENDER_ID Add loadAccountOrFailWith and validateUsable in Store which help to load the account from the state and throw the given code if an exception occurs due to an invalid account. Add new tests and modify old ones. --------- Signed-off-by: Zhivko Petkov <zhpetkov9@gmail.com>
steven-sheehy
requested changes
May 3, 2024
...mirror-web3/src/main/java/com/hedera/mirror/web3/evm/properties/MirrorNodeEvmProperties.java
Show resolved
Hide resolved
hedera-mirror-web3/src/main/java/com/hedera/services/txns/crypto/AbstractAutoCreationLogic.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Zhivko Petkov <zhpetkov9@gmail.com>
Signed-off-by: Zhivko Petkov <119669063+zhpetkov@users.noreply.github.com>
Signed-off-by: Zhivko Petkov <zhpetkov9@gmail.com>
|
Merged. |
kselveliev
approved these changes
May 7, 2024
steven-sheehy
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
AccessorBasedUsages#estimateCryptoTransfer - token multiplier
Add
MirrorNodeEvmPropertiesinAccessorBasedUsages,ServiceConfiguration. AddfeesTransferUsageMultiplierwith default value 380 inMirrorNodeEvmProperties. Set token multiplier value frommirrorNodeEvmPropertiesinAccessorBasedUsages. Modification inAccessorBasedUsagesTest.HederaSelfDestructOperationV038 - reasonToHalt missing if statements
Add
contractIsTokenTreasury,contractHasAnyBalance,contractOwnsNftsinHederaEvmStackedWorldStateUpdater, because they are needed inreasonToHaltstatements. Add more tests inHederaSelfDestructOperationV038-rejectsSelfDestructIfTreasury(),rejectsSelfDestructIfContractHasAnyTokenBalance(),rejectsSelfDestructIfContractHasAnyNfts().AbstractAutoCreationLogic#create - missing analyzeTokenTransferCreations part
Add
tokenAliasMap,analyzeTokenTransferCreationsandresetinAbstractAutoCreationLogic. AddgetTokenAliasMapinAutoCreationLogic. Add needed modifications inMirrorEvmMessageCallProcessorTest,TransferLogicTest,SyntheticTxnFactoryTest,TransferPrecompileTest. Add new tests inAutoCreationLogicTest.SyntethicTxnFactory#createHollowAccount - setMaxAutomaticTokenAssociations
Add
maxAutoAssociationsincreateHollowAccount.Related issue(s):
Fixes #8056
Fixes #8137
Notes for reviewer:
Checklist