-
Notifications
You must be signed in to change notification settings - Fork 108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add missing logics and validations from services part 1 #8074
Closed
zhpetkov
wants to merge
8
commits into
main
from
8056-add-missing-logics-and-validations-from-services-1
Closed
Add missing logics and validations from services part 1 #8074
zhpetkov
wants to merge
8
commits into
main
from
8056-add-missing-logics-and-validations-from-services-1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Zhivko Petkov <zhpetkov9@gmail.com>
Signed-off-by: Zhivko Petkov <zhpetkov9@gmail.com>
…ct-V38' into 8056-add-missing-logics-and-validations-from-services-1
Signed-off-by: Zhivko Petkov <zhpetkov9@gmail.com>
…8056-add-missing-logics-and-validations-from-services-1
zhpetkov
requested review from
steven-sheehy,
IvanKavaldzhiev,
bilyana-gospodinova and
kselveliev
April 12, 2024 14:27
zhpetkov
changed the title
Add missing logics and validations from services 1
Add missing logics and validations from services part 1
Apr 12, 2024
zhpetkov
added
limechain
Work planned for the LimeChain team
enhancement
Type: New feature
web3
Area: Web3 API
labels
Apr 12, 2024
Signed-off-by: Zhivko Petkov <zhpetkov9@gmail.com>
kselveliev
reviewed
Apr 15, 2024
...c/main/java/com/hedera/mirror/web3/evm/store/contract/HederaEvmStackedWorldStateUpdater.java
Show resolved
Hide resolved
Signed-off-by: Zhivko Petkov <zhpetkov9@gmail.com>
Quality Gate failedFailed conditions |
Need to fix DCO and conflicts |
2 tasks
steven-sheehy
deleted the
8056-add-missing-logics-and-validations-from-services-1
branch
April 24, 2024 14:36
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
AccessorBasedUsages#estimateCryptoTransfer - token multiplier
Add
MirrorNodeEvmProperties
inAccessorBasedUsages
,ServiceConfiguration
. AddfeesTransferUsageMultiplier
with default value 380 inMirrorNodeEvmProperties
. Set token multiplier value frommirrorNodeEvmProperties
inAccessorBasedUsages
. Modification inAccessorBasedUsagesTest
.HederaSelfDestructOperationV038 - reasonToHalt missing if statements
Add
contractIsTokenTreasury
,contractHasAnyBalance
,contractOwnsNfts
inHederaEvmStackedWorldStateUpdater
, because they are needed inreasonToHalt
statements. Add more tests inHederaSelfDestructOperationV038
-rejectsSelfDestructIfTreasury()
,rejectsSelfDestructIfContractHasAnyTokenBalance()
,rejectsSelfDestructIfContractHasAnyNfts()
.AbstractAutoCreationLogic#create - missing analyzeTokenTransferCreations part
Add
tokenAliasMap
,analyzeTokenTransferCreations
andreset
inAbstractAutoCreationLogic
. AddgetTokenAliasMap
inAutoCreationLogic
. Add needed modifications inMirrorEvmMessageCallProcessorTest
,TransferLogicTest
,SyntheticTxnFactoryTest
,TransferPrecompileTest
. Add new tests inAutoCreationLogicTest
.Related issue(s):
Fixes #8056
Notes for reviewer:
Checklist