Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing logics and validations from services part 1 #8056

Closed
Tracked by #8017
kselveliev opened this issue Apr 9, 2024 · 0 comments · Fixed by #8157
Closed
Tracked by #8017

Add missing logics and validations from services part 1 #8056

kselveliev opened this issue Apr 9, 2024 · 0 comments · Fixed by #8157
Assignees
Labels
enhancement Type: New feature limechain Work planned for the LimeChain team web3 Area: Web3 API
Milestone

Comments

@kselveliev
Copy link
Contributor

kselveliev commented Apr 9, 2024

Problem

After investigation in #7822 there are some missing logics and validations that are present in hedera-services but missing in mirror-node we need to add them.

Solution

HederaSelfDestructOperationV038 - reasonToHalt missing if statements
AccessorBasedUsages#estimateCryptoTransfer - token multiplier
ERCTransferPrecompile - extrapolateDetailsFromSyntheticTxn() method is missing
AbstractAutoCreationLogic#create - добавяне на analyzeTokenTransferCreations частта

We need to cover the new changes with tests.

Alternatives

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Type: New feature limechain Work planned for the LimeChain team web3 Area: Web3 API
Projects
Status: Done
Status: Done
3 participants