Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fixes unit test heap memory issue #2305

Merged
merged 33 commits into from
Apr 23, 2024
Merged

fix: fixes unit test heap memory issue #2305

merged 33 commits into from
Apr 23, 2024

Conversation

konstantinabl
Copy link
Collaborator

@konstantinabl konstantinabl commented Apr 9, 2024 •
edited

Description:

This PR addresses a memory issue occurring during unit tests execution.
In order to do this the openrpc.json file had to have a recursion, which led to exhaustion of memory, removed.

Additionally, the following changes has been made:

  • Tests that failed due to the memory issue disrupting the test workflow have been fixed. This includes removing irrelevant tests, such as the Gas tests in eth_call.spec.
  • Introduces Reds in memory server, which fixes all the tests, that were using RedisCache and were throwing ECONNREFUSED
  • The tsconfig file has been updated to include the sourceMap property, enabling debugging directly within TypeScript files.

Related issue(s):

Fixes #2300

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

@konstantinabl konstantinabl linked an issue Apr 9, 2024 that may be closed by this pull request
Unit Tests are failing with Fatal Error: Memory Leak #2300
Closed
@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 9, 2024 •
edited

Acceptance Tests

  14 files  193 suites   15m 47s ⏱️
578 tests 573 ✔️ 4 💤 1 ❌
612 runs  606 ✔️ 4 💤 2 ❌

Results for commit 5c2744c.

♻️ This comment has been updated with latest results.

@konstantinabl konstantinabl force-pushed the 2300-unit-tests-are-failing-with-fatal-error-memory-leak branch from 499c951 to 2b9e18a Compare April 9, 2024 15:46
@konstantinabl konstantinabl changed the title fix: revert wrong commit fix: fixes unit test heap memory issue Apr 9, 2024
@konstantinabl konstantinabl force-pushed the 2300-unit-tests-are-failing-with-fatal-error-memory-leak branch 14 times, most recently from dbf79bb to f354474 Compare April 17, 2024 19:58
@konstantinabl
fixes infinte recursion in openrpc.json
5c08868 
Signed-off-by: Konstantina Blazhukova <konstantina.blajukova@gmail.com>
@konstantinabl
Improves subscription controller
8c7097f 
Signed-off-by: Konstantina Blazhukova <konstantina.blajukova@gmail.com>
@konstantinabl
Fixes failing unit tests
48aacf4 
Signed-off-by: Konstantina Blazhukova <konstantina.blajukova@gmail.com>
@konstantinabl
Removes unecessary test related to historical blocks
8e3b2ce 
Signed-off-by: Konstantina Blazhukova <konstantina.blajukova@gmail.com>
@konstantinabl
removes tests for delete file since they are not working and are not …
384108d 
…useful

Signed-off-by: Konstantina Blazhukova <konstantina.blajukova@gmail.com>
@konstantinabl
test
f70be4f 
Signed-off-by: Konstantina Blazhukova <konstantina.blajukova@gmail.com>
@konstantinabl
Uncomment eth_call
e0c6864 
Signed-off-by: Konstantina Blazhukova <konstantina.blajukova@gmail.com>
@konstantinabl
Make improvements to the redisCache class so we ensure the Redis clie…
721c67a 
…nt is ready when using set/get/multiset etc.

Signed-off-by: Konstantina Blazhukova <konstantina.blajukova@gmail.com>
@konstantinabl
Makes clear method in the cache service async
9e8167b 
Signed-off-by: Konstantina Blazhukova <konstantina.blajukova@gmail.com>
@konstantinabl
Fixes failing tests in getblockBy
ed99a84 
Signed-off-by: Konstantina Blazhukova <konstantina.blajukova@gmail.com>
@konstantinabl
Adds sourceMap property to tsconfig so we can test upon ts files
71c881b 
Signed-off-by: Konstantina Blazhukova <konstantina.blajukova@gmail.com>
@konstantinabl
Uncomments commented tests
8649aef 
Signed-off-by: Konstantina Blazhukova <konstantina.blajukova@gmail.com>
konstantinabl and others added 6 commits April 22, 2024 13:59
@konstantinabl @victor-yanev
Update packages/relay/src/lib/clients/cache/ICacheClient.ts
a1b3e18 
Co-authored-by: Victor Yanev <161485803+victor-yanev@users.noreply.github.com>
Signed-off-by: konstantinabl <konstantina.blajukova@gmail.com>
@konstantinabl @victor-yanev
Update packages/relay/src/lib/clients/cache/ICacheClient.ts
68532b8 
Co-authored-by: Victor Yanev <161485803+victor-yanev@users.noreply.github.com>
Signed-off-by: konstantinabl <konstantina.blajukova@gmail.com>
@konstantinabl
Extends return types in ICacheClient
a3fa8d7 
Signed-off-by: Konstantina Blazhukova <konstantina.blajukova@gmail.com>
@konstantinabl
Improves code readability by reomving magic numbers
259ff4d 
Signed-off-by: Konstantina Blazhukova <konstantina.blajukova@gmail.com>
@konstantinabl @victor-yanev
Update packages/relay/tests/redisInMemoryServer.ts return types
241f301 
Co-authored-by: Victor Yanev <161485803+victor-yanev@users.noreply.github.com>
Signed-off-by: konstantinabl <konstantina.blajukova@gmail.com>
@konstantinabl @victor-yanev
Update packages/relay/tests/redisInMemoryServer.ts return types
88385c9 
Co-authored-by: Victor Yanev <161485803+victor-yanev@users.noreply.github.com>
Signed-off-by: konstantinabl <konstantina.blajukova@gmail.com>
victor-yanev
victor-yanev previously approved these changes Apr 22, 2024
View reviewed changes
@konstantinabl
Reverts changes to ICacheClient interface
5c2744c 
Signed-off-by: Konstantina Blazhukova <konstantina.blajukova@gmail.com>
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Apr 22, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
8.3% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

@konstantinabl konstantinabl mentioned this pull request Apr 22, 2024
Closed
victor-yanev
victor-yanev approved these changes Apr 23, 2024
View reviewed changes
Copy link
Contributor

@victor-yanev victor-yanev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

ebadiere
ebadiere approved these changes Apr 23, 2024
View reviewed changes
Copy link
Collaborator

@ebadiere ebadiere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG.

@ebadiere ebadiere merged commit f66da4e into main Apr 23, 2024
27 of 28 checks passed
@ebadiere ebadiere deleted the 2300-unit-tests-are-failing-with-fatal-error-memory-leak branch April 23, 2024 13:25
quiet-node added a commit that referenced this pull request Apr 23, 2024
@quiet-node
Revert "fix: fixes unit test heap memory issue (#2305)"
c32fe7c 
This reverts commit f66da4e.
@quiet-node quiet-node mentioned this pull request May 7, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ebadiere ebadiere ebadiere approved these changes

@victor-yanev victor-yanev victor-yanev approved these changes

@AlfredoG87 AlfredoG87 Awaiting requested review from AlfredoG87 AlfredoG87 is a code owner

@Nana-EC Nana-EC Awaiting requested review from Nana-EC Nana-EC is a code owner

@lukelee-sl lukelee-sl Awaiting requested review from lukelee-sl lukelee-sl is a code owner

@Ivo-Yankov Ivo-Yankov Awaiting requested review from Ivo-Yankov

@natanasow natanasow Awaiting requested review from natanasow

@quiet-node quiet-node Awaiting requested review from quiet-node

@georgi-l95 georgi-l95 Awaiting requested review from georgi-l95

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unit Tests are failing with Fatal Error: Memory Leak
4 participants
@konstantinabl @ebadiere @georgi-l95 @victor-yanev