Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deleteFile() unit test is not working correctly #2374

Closed
quiet-node opened this issue Apr 19, 2024 · 1 comment
Closed

deleteFile() unit test is not working correctly #2374

quiet-node opened this issue Apr 19, 2024 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@quiet-node
Copy link
Collaborator

Description

This PR #2243 attempted to enhance the SDKClient class by adding a deleteFile() function to aid in deleting files created during contract deployment transactions using the Hedera SDK. However, the accompanying unit test suite for the deleteFile() function fails to function properly in a local environment where no Hedera network is configured.

The deleteFile() function relies on the SDK to delete a file from the Hedera network. In the context of the Relay unit test, there is no configured server. Consequently, when the unit test initializes an sdkClient instance, the client has no server (Hedera network) to connect to. As a result, the tests hang and eventually time out.

Given these circumstances, it might be efficient enough to incorporate deleteFile() coverage into the acceptance test rather than the unit test, which has already been done. Thus, the possible solution is to remove the unit test suite for deleteFile().

Steps to reproduce

  1. Run the unit test for Relay exclusively for del;eteFile() suite
  2. Observe the test hangs and eventually timed out

Additional context

No response

Hedera network

mainnet, testnet, previewnet, other

Version

latest

Operating system

None

@quiet-node quiet-node added the bug Something isn't working label Apr 19, 2024
@quiet-node quiet-node self-assigned this Apr 19, 2024
@quiet-node
Copy link
Collaborator Author

fixed in #2305

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Done
Development

No branches or pull requests

1 participant