-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deselect event #586
Deselect event #586
Conversation
Thanks so much, @dingram. It's almost always a good idea to keep pull requests in more logical groupings -- so that their individual merits can be discussed. I'm going to weigh in on some stuff and then would welcome you to resubmit that way.
Please submit the
As mentioned in #516, there is already an html attribute that makes sense to use here. Any element that is Additionally, as this is built now, it won't work. Simply hiding the
I'm not sure what the use case is for this. Why would you want to stop a selection instead of using the disabled attribute discussed for the second portion? Feel free to continue the discussion here, but I'm going to close this pull request. After a discussion, I'd welcome you to re-open numbers 2 & 3 if appropriate. Thanks again. |
Yeah, sure. Looking at it from the point of view of the project owner, these should definitely have been at least two requests; my apologies. I'll submit the
That makes complete sense, and I should have thought of it before. I'll look into updating the code to handle things that way instead.
Heh, thanks -- I'd completely missed that possibility. I'll make sure I take it into account too.
That's a good point, and I hadn't considered it. I now can't think of any reasoning for this :-( |
Thanks for following up, @dingram. If you get a version working with disabled elements and some kind of style change, I'd love to see it resubmitted. It'd be worthy of a merge for sure. |
A few things in this pull request -- let me know if you'd prefer them to be seperate.
Cakefile
so it doesn't conflict with the node.js reserved wordpackage
data-removable
attribute onoption
elements in a multiple-select box, which can be set to "0" in order to stop them being deselectedliszt:deselect
event, so runtime code can decide whether to allow an item to be deselected. This can be prevented by calling thepreventDefault()
(jQuery) orstop()
(Prototype) methods on the event object.