Implement handling of options that are both disabled AND selected #592
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows Chosen to deal with items that are both disabled and selected (i.e. should show as selected but should not be deselectable). See also #516 and #586.
These changes include:
This change does not update the compiled files, as I appear to have a different version of coffeescript (or different options), and didn't want to create needless changeset noise. This can be updated, however.
Prototype fix
I noticed that in
keydown_backstroke
(around line 490), it was calling:but Prototype does not accept a selector argument to
siblings()
, so this was doing nothing. In order to replicate the functionality from jQuery, it would have to be something like:with an additional tag name check. In any event, I updated the code to use:
as I needed to exclude disabled items, and it appeared to be doing the right thing anyway.