Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Raising CanOperationError if the bus is not open on some methods call #1765

Merged
merged 4 commits into from Apr 17, 2024
Merged

Raising CanOperationError if the bus is not open on some methods call #1765

merged 4 commits into from Apr 17, 2024

Conversation

pierreluctg
Copy link
Collaborator

@pierreluctg pierreluctg commented Apr 16, 2024 •
edited

Raising can.exceptions.CanOperationError if the bus is not open on some methods call.

Fixes #1740 by raising can.exceptions.CanOperationError instead of causing a segmentation fault.

@pierreluctg
Raising :exc:~can.exceptions.CanOperationError if the bus is not op…
f45d53f 
…en on some methods call

Raising :exc:`~can.exceptions.CanOperationError` if the bus is not open on some methods call
@pierreluctg pierreluctg marked this pull request as ready for review April 16, 2024 15:56
@pierreluctg pierreluctg mentioned this pull request Apr 16, 2024
Closed
@pierreluctg
Update neovi_bus.py
fd2eb24 
Improving docstring
zariiii9003
zariiii9003 approved these changes Apr 16, 2024
View reviewed changes
Copy link
Collaborator

@zariiii9003 zariiii9003 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. The formatting needs to be fixed though.

@pierreluctg
Copy link
Collaborator Author

Looks good. The formatting needs to be fixed though.

Fixed

@pierreluctg pierreluctg merged commit 7dba449 into main Apr 17, 2024
58 checks passed
@pierreluctg pierreluctg deleted the neovi-is-bus-open branch April 17, 2024 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zariiii9003 zariiii9003 zariiii9003 approved these changes

@felixdivo felixdivo Awaiting requested review from felixdivo

Assignees
No one assigned
Labels
backend:neovi bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Segmentation fault when calling ics.close_device()
2 participants
@pierreluctg @zariiii9003