Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: load token from url query parameter #50

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

feat: load token from url query parameter #50

wants to merge 4 commits into from

Conversation

lallenfrancisl
Copy link
Contributor

Fixes #49

@lallenfrancisl
Copy link
Contributor Author

lallenfrancisl commented Sep 1, 2022 •
edited

I have also updated the validator and some old tests in consideration of the new parameter

@lallenfrancisl
Copy link
Contributor Author

@Marsup Could you review this ?

@kanongil
Copy link

I'm not a fan of adding support for a use case that is likely to inadvertently expose the tokens to standard logging tools.

The url including the query part is included in most HTTP server logs, and can also easily be exposed by clients through system logs. Probably better explained in this SO answer.

@lallenfrancisl
Copy link
Contributor Author

lallenfrancisl commented Mar 23, 2023 •
edited

@kanongil But what about use cases like signed urls from signup links and stuff ? Isn't these best left to the user of the library ?

@mautematico mautematico mentioned this pull request May 13, 2023
Open
@lallenfrancisl
Copy link
Contributor Author

@kanongil @Marsup Any chance this can be re-evalutated ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Accept token from url search query param
2 participants
@lallenfrancisl @kanongil