Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accept token from url search query param #49

Open
lallenfrancisl opened this issue Aug 30, 2022 · 2 comments · May be fixed by #50
Open

Accept token from url search query param #49

lallenfrancisl opened this issue Aug 30, 2022 · 2 comments · May be fixed by #50
Labels
feature New functionality or improvement

Comments

@lallenfrancisl
Copy link
Contributor

lallenfrancisl commented Aug 30, 2022

Support plan

Community

  • is this issue currently blocking your project? (yes/no): yes
  • is this issue affecting a production system? (yes/no): yes

Context

Some apps need the ability to parse token from url. A usecase would be to implement reset password links.

  • node version: 16.0.0
  • module version: 3.0.0
  • environment (e.g. node, browser, native): node
  • used with (e.g. hapi application, another framework, standalone, ...): hapi application
  • any other relevant information:

What problem are you trying to solve?

Allow the plugin to read token from url search query param. Something like https://api.test.com?token=sdfsdfsdfsf would be read and parsed

Implementing this opens up the plugin to a wide variety of usecases, like email reset password links, token based file access etc

Do you have a new or modified API suggestion to solve the problem?

Yes, this can be done similar to what we did with cookieName

@lallenfrancisl lallenfrancisl added the feature New functionality or improvement label Aug 30, 2022
@lallenfrancisl lallenfrancisl linked a pull request Sep 1, 2022 that will close this issue
@pelov
Copy link

pelov commented Mar 20, 2023

Any chance that this gets fixed soon? Reading tokens from query parameters is useful in certain scenarios and I was surprised that the library doesn't support it.

@mautematico
Copy link
Contributor

@pelov see #50

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New functionality or improvement
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants