[compiler] declarative Bindings
#14496
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @patrick-schultz and the rest of your teammates on |
patrick-schultz
force-pushed
the
ps-04-18-delete_old_binds_implementation
branch
from
e5dbfd8
to
0e3fa29
Compare
patrick-schultz
force-pushed
the
ps-04-22-push_through_declarative_bindings
branch
from
555605d
to
50b9a7d
Compare
patrick-schultz
changed the base branch from
ps-04-18-delete_old_binds_implementation
to
main
patrick-schultz
changed the base branch from
main
to
ps-04-18-delete_old_binds_implementation
patrick-schultz
changed the title
Bindings
ehigham
requested changes
Apr 25, 2024
patrick-schultz
force-pushed
the
ps-04-18-delete_old_binds_implementation
branch
from
0e3fa29
to
f99f199
Compare
patrick-schultz
force-pushed
the
ps-04-22-push_through_declarative_bindings
branch
2 times, most recently
from
21bbe7a
to
af1ac6e
Compare
ehigham
approved these changes
Apr 29, 2024
patrick-schultz
force-pushed
the
ps-04-18-delete_old_binds_implementation
branch
from
f99f199
to
d3760b9
Compare
patrick-schultz
force-pushed
the
ps-04-22-push_through_declarative_bindings
branch
from
af1ac6e
to
5a13d5a
Compare
patrick-schultz
force-pushed
the
ps-04-18-delete_old_binds_implementation
branch
from
d3760b9
to
04f9a52
Compare
patrick-schultz
force-pushed
the
ps-04-22-push_through_declarative_bindings
branch
from
5a13d5a
to
b63c0f5
Compare
Merge activity
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactors
Bindingsto return an object encoding the change to the environment (any new bindings, whether the agg/scan env is promoted, etc). This allows the deletion ofSegregatedBindingEnv. Follow up work will use this to replace the other specializations ofGenericBindingEnv, and to greatly simplify compiler passes, such asNormalizeNamesandPruneDeadFields, which currently need to redundantly encode the binding structure of every node.