[compiler] consolidate BindingEnv interface #14475
Merged
+522
−56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @patrick-schultz and the rest of your teammates on |
patrick-schultz
force-pushed
the
ps-04-16-use_declarative_encoding_in_Binds
branch
7 times, most recently
from
1a5d15b
to
8a060f9
Compare
This was referenced Apr 22, 2024
patrick-schultz
force-pushed
the
ps-04-16-use_declarative_encoding_in_Binds
branch
from
8a060f9
to
f1a3628
Compare
patrick-schultz
changed the title
ehigham
reviewed
Apr 24, 2024
patrick-schultz
force-pushed
the
ps-04-16-use_declarative_encoding_in_Binds
branch
from
f1a3628
to
816819e
Compare
patrick-schultz
force-pushed
the
ps-04-16-use_declarative_encoding_in_Binds
branch
from
816819e
to
bf95f99
Compare
hail-ci-robot
pushed a commit
that referenced
this pull request
May 1, 2024
Follows up on #14475 by deleting the old implementation of `Bindings` in favor of the new one, which has now been checked by CI to not change the behavior.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a step towards coralling the specification of the binding structure of the IR into one place, this rewrites
Bindingsto use only a single method of theGenericBindingEnvinterface,newBlock, which therefore captures all possibilities of how a node can modify its parent's environment in a child. Later work refactors this to return an object encoding this modification, instead of returning a modified environment, which allows the caller complete flexibility in how to maintain an environment appropriately for their use case.This PR leaves in the old
Bindingsimplementation, with an assertion that they agree. The PR stacked above this, #14495, deletes the old implementation. This way CI asserts that this refactoring hasn't changed any behavior.