Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add missing type exports, prevent moving dist files to avoid breaking "npm link" feature #149

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

az0uz
Copy link
Contributor

@az0uz az0uz commented Dec 15, 2023

  • Keep build files in the dist directory. Moving them to the root and exposing them from the root in the package.json breaks things when you are using npm link with npm start to test new changes while developing other projects.
  • Add missing type exports, some types that are used in publicly accessible APIs are not importable by external users. This PR add them to the exports field in package.json

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant