New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add missing type exports, prevent moving dist files to root #150

Closed

az0uz wants to merge 4 commits into gzuidhof:master from az0uz:az0uz/fix_exports

Contributor

az0uz commented Dec 30, 2023

some types are not exported, it is very useful to let users access public API types so they don't have to re-define type of objects passed to the zarr.js api.
keeps build files in dist/ instead of moving them to the root dir, moving them breaks development workflow when using npm link && npm run start and npm run link zarr in another project to use the current dev version of zarr.
remove hooks to copy and git clean before / after build

az0uz added 4 commits

December 30, 2023 12:59


          add missing type exports, prevent moving dist files

c1781d7


          bundle files, drop postpublish git clean

f76ea91


          bundle all files in dist/


          restore simple prepublish hook

8d8ee02

Contributor Author

az0uz commented Dec 30, 2023

Sorry I already created a PR for this 😅 Duplicate of #149

az0uz closed this

az0uz deleted the az0uz/fix_exports branch

December 30, 2023 13:31

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment