Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUGFIX] SQL dialect doesn't register for BigQuery for V2 #3324

Merged
merged 14 commits into from
Aug 27, 2021
Merged

[BUGFIX] SQL dialect doesn't register for BigQuery for V2 #3324

Changes from all commits
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
d684ac8
Resolved sorting and variable assignation error
talagluck Jul 21, 2021
f9a4342
Revert "Resolved sorting and variable assignation error"
talagluck Jul 22, 2021
b75dae3
Merge branch 'develop' of github.com:great-expectations/great_expecta…
talagluck Jul 26, 2021
2ceb9d7
Merge branch 'develop' of github.com:great-expectations/great_expecta…
talagluck Jul 26, 2021
da2fec0
Merge branch 'develop' of github.com:great-expectations/great_expecta…
talagluck Jul 27, 2021
3577b3a
Merge branch 'develop' of github.com:great-expectations/great_expecta…
talagluck Aug 5, 2021
73f510c
Merge branch 'develop' of github.com:great-expectations/great_expecta…
talagluck Aug 11, 2021
f6555e2
Merge branch 'develop' of github.com:great-expectations/great_expecta…
talagluck Aug 16, 2021
37d188e
Merge branch 'develop' of github.com:great-expectations/great_expecta…
talagluck Aug 18, 2021
63da0f5
Merge branch 'develop' of github.com:great-expectations/great_expecta…
talagluck Aug 24, 2021
59e4f99
Merge branch 'develop' of github.com:great-expectations/great_expecta…
talagluck Aug 24, 2021
66ae77d
Merge branch 'develop' of github.com:great-expectations/great_expecta…
talagluck Aug 26, 2021
9f4ef36
Merge branch 'develop' of github.com:great-expectations/great_expecta…
talagluck Aug 27, 2021
0bdcdfd
remove line preventing sql dialect from registering for bigquery
talagluck Aug 27, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 0 additions & 1 deletion great_expectations/dataset/sqlalchemy_dataset.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -560,7 +560,6 @@ def __init__(
"sqlite",
"oracle",
"mssql",
"bigquery",
]:
# These are the officially included and supported dialects by sqlalchemy
self.dialect = import_library_module(
Expand Down