[BUGFIX] SQL dialect doesn't register for BigQuery for V2 #3324
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit d684ac8.
…tions into develop
…tions into develop
…tions into develop
…tions into develop
…tions into develop
…tions into develop
…tions into develop
…tions into develop
…tions into develop
…tions into develop
…tions into develop
|
✔️ Deploy Preview for niobium-lead-7998 ready! 🔨 Explore the source changes: 0bdcdfd 🔍 Inspect the deploy log: https://app.netlify.com/sites/niobium-lead-7998/deploys/61292a7d5586be000896fe1b 😎 Browse the preview: https://deploy-preview-3324--niobium-lead-7998.netlify.app |
HOWDY! This is your friendly 🤖 CHANGELOG bot 🤖Please don't forget to add a clear and succinct description of your change under the Develop header in ✨ Thank you! ✨ |
Shinnnyshinshin
approved these changes
Aug 27, 2021
There was a problem hiding this comment.
oh my goodness. Thank you so much for catching this @talagluck. You're absolutely right 😅
talagluck
deleted the
bugfix/GREAT-166/fix_bigquery_sql_dialect_issue_for_v2
branch
Shinnnyshinshin
pushed a commit
that referenced
this pull request
Aug 30, 2021
…tations/great_expectations into MAINTENANCE/GDOC-219/tests_datasource_sparkdf_pandas * 'MAINTENANCE/GDOC-219' of https://github.com/great-expectations/great_expectations: [MAINTENANCE] Tests for RuntimeDataConnector at DataContext-level (#3304) [BUGFIX] SQL dialect doesn't register for BigQuery for V2 (#3324) [WIP] [FEATURE] add backend args to run_diagnostics (#3257)
Shinnnyshinshin
pushed a commit
to jdimatteo/great_expectations
that referenced
this pull request
Aug 31, 2021
…matteo/great_expectations into feature/add_performance_test * 'feature/add_performance_test' of https://github.com/jdimatteo/great_expectations: [MAINTENANCE] Tests for RuntimeDataConnector at Datasource-level (Spark and Pandas) (great-expectations#3318) [MAINTENANCE] Tests for RuntimeDataConnector at DataContext-level (great-expectations#3304) [BUGFIX] SQL dialect doesn't register for BigQuery for V2 (great-expectations#3324) [WIP] [FEATURE] add backend args to run_diagnostics (great-expectations#3257) Release Prep release-prep-2021-08-26 (great-expectations#3320) Docs] hide stubbed core skills (great-expectations#3316) [MAINTENANCE] Write integration/E2E tests for both `GCSDataConnectors` (great-expectations#3301) [DOCS] Standardize capitalization of various technologies in `docs` (great-expectations#3312) [DOCS] Fix misc errors in "How to create renderers for Custom Expectations" (great-expectations#3315) docs: Remove misc TODOs to tidy up docs (great-expectations#3313) [DOCS] GDOC-217 remove stub links (great-expectations#3314) [FEATURE] Enable `GCS DataConnector` integration with `PandasExecutionEngine` (great-expectations#3264)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request:
This reverts that change. I believe this resolves both #3308 and #3261 .
Definition of Done
Please delete options that are not relevant.
Thank you for submitting!