Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add healthcare=laboratory #4402

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

corentinfuret
Copy link

Changes proposed in this pull request:

  • Laboratories became facilities of major importance during the last year. These modifications will render healthcare=laboratory. At zoom 17 it will be only a red dot to be less visible than doctors or pharmacy. At zoom 18 and higher the full name and the icon will be displayed.

The icon came from The Noun Project (https://thenounproject.com/term/microscope/648/), has been adjusted to fit openstreetmap-carto guidelines by cquest and is under CC0.

Test rendering with links to the example places:
https://www.openstreetmap.org/#map=19/47.46202/-0.55274

Before
example_laboratory_void_final

After
example_laboratory_final

@imagico
Copy link
Collaborator

imagico commented May 9, 2021

healthcare=laboratory has 7400 uses.

If this is merged it should be preceded or combined with a fix for #4403 - otherwise the code in amenity-points.mss will get even more confusing.

I am generally wary of adding new POIs before fixing #3880. I also have doubts with the use of the healthcare color for features that by mapping conventions do not necessarily indicate facilities which provide services open to the public.

@jeisenbe
Copy link
Collaborator

I agree that #4403 needs to be fixed. We should also think about this systematically.

There are 2 other healthcare=* feature which are more common and which are not rendered yet:

And there are several other healthcare=* tags which are fairly common but not rendered. It may make sense to address several of these at once.
healthcare=psychotherapist - 4023 uses - https://taginfo.openstreetmap.org/tags/healthcare=psychotherapist
healthcare=rehabilitation - 2370 uses - https://taginfo.openstreetmap.org/tags/healthcare=rehabilitation
healthcare=podiatrist - 2140 uses - https://taginfo.openstreetmap.org/tags/healthcare=podiatrist
healthcare=optometrist - 2710 uses - https://taginfo.openstreetmap.org/tags/healthcare=optometrist

Also see less common tags: #4222 healthcare=blood_donation, #4295 healthcare=vaccination_centre

We previously closed #3706 and #3609 about healthcare=counselling, and healthcare=nurse which were rare at the time.

@@ -605,6 +605,18 @@
marker-clip: false;
}

[feature = 'healthcare_laboratory'][zoom >= 17] {
[zoom >= 17][zoom < 18] {
marker-width: 4;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We do not currently use any dots in this color. I do not think it will be intuitive

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants