Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

healthcare=laboratory has no icon just a dot #3594

Closed
532910 opened this issue Dec 24, 2018 · 15 comments
Closed

healthcare=laboratory has no icon just a dot #3594

532910 opened this issue Dec 24, 2018 · 15 comments
Labels
new features Requests to render new features POI

Comments

@532910
Copy link

532910 commented Dec 24, 2018

Bad:
bad

Good:
good

@polarbearing
Copy link
Contributor

If you consider this style bad, why do you use it?

@kocio-pl
Copy link
Collaborator

kocio-pl commented Dec 25, 2018

I don't think that everything should have an icon in OSM Carto. It's important that the color of the dot is not random and says something (red -> health, dark blue -> office, violet -> shop), but it can stay this way.

It would help if you have some design we could use, otherwise I think this ticket should be closed.

@532910
Copy link
Author

532910 commented Dec 25, 2018

If you consider this style bad, why do you use it?

I don't use it.

@Adamant36
Copy link
Contributor

Adamant36 commented Dec 25, 2018

Outside of echoing what @polarbearing said, you should be more specific. "a lot of other poi" is way to vague. There's obviously going to some things that don't have icon due to either low numbers or just being to specialized for this style. So which POI's specifically would you like to see added? healthcare=laboratory has over a thousand uses and it could be something like a beaker (the container. Not the Sesame Street character). So that's a possibility at least.

Edit: If you don't use it, its kind of pointless to complain about it then. And no, we can't.

@532910
Copy link
Author

532910 commented Dec 25, 2018

It would help if you have some design we could use, otherwise I think this ticket should be closed.

Could you just use same icons as in iD editor?

@kocio-pl
Copy link
Collaborator

They don't work for me in this style.

@matkoniecz
Copy link
Contributor

Could you just use same icons as in iD editor?

In cases where icon works well and license of image file is CC0 or public domain - we can use it. But you should be more specific.

@Tomasz-W
Copy link

As we have a lot of things to show in OSM-Carto, we have to show some of them in simplest and less prominent possible way (e.g. by dots for healtcare and office objects or squares for public transport stops). If we would use dedicated icons for all features, map propably would look like this:

@matkoniecz matkoniecz changed the title healthcare=laboratory and a lot of other poi has no icon just a dot healthcare=laboratory has no icon just a dot Dec 25, 2018
@matkoniecz
Copy link
Contributor

matkoniecz commented Dec 25, 2018

I changed the title to make this issue fixable. If some other tags should be rendered with icon - open an issue for them if no issue exists for them.

I considered closing this as declined and opening new one for just laboratory, but this version should be less confusing.

@thep
Copy link

thep commented Jan 15, 2020

healthcare=laboratory has over a thousand uses and it could be something like a beaker (the container. Not the Sesame Street character). So that's a possibility at least.

I asked medical lab people and they said a microscope should represent their work best. A beaker or a flask could still be read as a chemical lab instead.

@Adamant36
Copy link
Contributor

A side view of a microscope probably wouldn't be to hard of an icon to make. It would probably be easier to tell its a lab
icon compared to a beaker also.

@jeisenbe
Copy link
Collaborator

Note that we cannot render anything tagged under the healthcare=* key until the next database reload. This could happen sooner rather than later, but someone will need to submit a PR which adds healthcare=* as a polygon key in the openstreetmap-carto.lua file. See #3611

@Adamant36
Copy link
Contributor

Adamant36 commented Jan 17, 2020

Note that we cannot render anything tagged under the healthcare=* key until the next database reload. This could happen sooner rather than later, but someone will need to submit a PR which adds healthcare=* as a polygon key in the openstreetmap-carto.lua file.

Hopefully correctly done in PR #4005

@imagico
Copy link
Collaborator

imagico commented May 9, 2021

This issue in the current form is invalidated by #3731. We should either close it or the issue opener should re-formulate it to adding rendering of healthcare=laboratory, see also #4402.

@jeisenbe
Copy link
Collaborator

Closing since the original concern is no longer valid

@jeisenbe jeisenbe added the new features Requests to render new features label Jun 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new features Requests to render new features POI
Projects
None yet
Development

No branches or pull requests

9 participants