VariableSelect: Multi select design update and behavior improvements #709
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
torkelo
added
release
This was referenced Apr 27, 2024
Merged
dprokop
reviewed
Apr 29, 2024
|
@dprokop updated the group by variable as well |
dprokop
reviewed
Apr 29, 2024
Comment on lines
+201
to
+215
| if (action === 'input-change') { | ||
| setInputValue(value); | ||
| if (model.onSearchChange) { | ||
| model.onSearchChange!(value); | ||
| } | ||
| : undefined; | ||
| return value; | ||
| } | ||
|
|
||
| if (action === 'input-blur') { | ||
| setInputValue(''); | ||
| return ''; | ||
| } | ||
|
|
||
| return inputValue; | ||
| }; |
There was a problem hiding this comment.
This seems to have a different effect compared to i.e. QueryVariable - selecting value (with Enter) also clears the search string, so that the list is no longer filtered.
There was a problem hiding this comment.
@dprokop missed setting inputValue={inputValue} on the Select.
But to really fix the issue of search not clearing you need to be on this branch in main grafana/grafana#87013
dprokop
approved these changes
May 1, 2024
|
🚀 PR was released in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Variables---Demos---Scenes-Test-App---Apps---Grafana.mp4
📦 Published PR as canary version:
4.14.0--canary.709.8892811931.0✨ Test out this PR locally via:
npm install @grafana/scenes@4.14.0--canary.709.8892811931.0 # or yarn add @grafana/scenes@4.14.0--canary.709.8892811931.0