New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Select: Fixes issue preserving search term (input) when selecting a value #87013
Conversation
Hello @torkelo!
Please, if the current pull request addresses a bug fix, label it with the |
This PR must be merged before a backport PR will be created. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good from my point of view.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small typo, I presume
Fixes an issue with preserving the search query & filtering after selecting a value, even after doing the correct onInputChange implementation according to the react select docs it did not work as our middleware implementation did not take into account scenarios where we want to preserve the search query after selection and always cleared the "hasInputValue" state which sets filterOption to null which disabled search filtering.
Related to grafana/scenes#709