Make options.hosts case insensitive #3653
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joanlopez
requested review from
mstoykov and
oleiade
and removed request for
a team
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3653 +/- ##
==========================================
- Coverage 73.58% 73.50% -0.09%
==========================================
Files 277 275 -2
Lines 20244 20242 -2
==========================================
- Hits 14896 14878 -18
- Misses 4400 4410 +10
- Partials 948 954 +6
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
mstoykov
approved these changes
Mar 18, 2024
oleiade
approved these changes
Mar 18, 2024
joanlopez
added a commit
that referenced
this pull request
Mar 18, 2024
oleiade
added a commit
that referenced
this pull request
Mar 25, 2024
* Add k6 v0.50.0 release notes * Add changes for the goja refactors in browser * Update release notes/v0.50.0.md Co-authored-by: İnanç Gümüş <inanc.gumus@grafana.com> * Add browser#1163 to release notes * Add browser#1205 to release notes (#3584) * Add 1215 to release notes * Update release notes/v0.50.0.md Co-authored-by: İnanç Gümüş <inanc.gumus@grafana.com> * Add screenshot upload to release notes * Update wording for screenshot upload update * Add browser 1209 to release notes (#3604) * Add browser 1217 to release notes (#3603) * Add browser 850 and Go 1.20 PRs to release notes (#3605) * Add browser 1220 and 1221 to release notes * Add/browser 1112 to release notes (#3624) * Add grafana/xk6-browser#1112 * Rephrase browser 1112 to release notes Co-authored-by: Ankur <ankur.agarwal@grafana.com> * Add better error pr for browser evaluate APIs * Add browser testRunId inject prs to release note * Update the verb * Add details of browser#1238 to release notes * Add details of browser#1097 to release notes * Apply suggestions from code review Co-authored-by: İnanç Gümüş <inanc.gumus@grafana.com> * JWK, options.cloud and some other changelogs * Link webcrypto JWK import/export to PR * Add browser#1241 to release notes * Update the browser#1097 release notes The API has changed so that it requires working with the experimental fs module to upload files from the local file system. * Add browser 986 (#3652) * Add browser 986 * Update add browser 1246 Co-authored-by: Ankur <ankur.agarwal@grafana.com> * Add k6/timers stabilization release notes * Add #3653 to release notes * Apply suggestions from code review Co-authored-by: Heitor Tashiro Sergent <heitortsergent@gmail.com> * Add notice for async browser API breaking change * Apply suggestions from code review Co-authored-by: İnanç Gümüş <inanc.gumus@grafana.com> * Add await explanation on non thenable * Add release changes top-level summary * Apply suggestions from code review Co-authored-by: Mihail Stoykov <312246+mstoykov@users.noreply.github.com> * Remove placeholders --------- Co-authored-by: ankur22 <ankur.agarwal@grafana.com> Co-authored-by: İnanç Gümüş <inanc.gumus@grafana.com> Co-authored-by: Oleg Bespalov <oleg.bespalov@grafana.com> Co-authored-by: Mihail Stoykov <M.Stoikov@gmail.com> Co-authored-by: Joan López de la Franca Beltran <joanjan14@gmail.com> Co-authored-by: Heitor Tashiro Sergent <heitortsergent@gmail.com> Co-authored-by: Mihail Stoykov <312246+mstoykov@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
It updates the
Hoststype constructorNewHostsstoresourcekeys (i.e. hosts) lowercased, to consider them case insensitive. The internal trie, and theHosts.Matchis already considering them insensitive, as they're treated as lowercase.Why?
Because otherwise,
options.hostsdoesn't work well with non-lowercase hosts.Checklist
make lint) and all checks pass.make tests) and all tests pass.Related PR(s)/Issue(s)
Closes #3651
Also related with #3620